Summary

Fix the display of a pop-up menu from a configforms list item.

Review Request #11326 — Created Dec. 9, 2020 and submitted Dec. 16, 2020, 2:17 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Configforms list items with a pop-up menu action button weren't styling
correctly in Djblets 2.0. We had changed the structure of pop-up menus,
but didn't change the code setting up that structure.

This change adds the new structure, and also fixes up some styling
around the menu.

Testing Done

Unit tests passed.

Tested some of our UI that uses this feature. Saw that, instead of a broken
transparent menu, I had a menu in the same appearance as in Djblets 1.0.

Commits

Summary	ID
Fix the display of a pop-up menu from a configforms list item. Configforms list items with a pop-up menu action button weren't styling correctly in Djblets 2.0. We had changed the structure of pop-up menus, but didn't change the code setting up that structure. This change adds the new structure, and also fixes up some styling around the menu.	80207d9d1f822ebf15c30906e1b99c28955f493d

Files

Issues

Description	From	Last Updated
Can you add a screenshot?	david	Dec. 16, 2020, 12:16 p.m.
This needs a trailing comma.	david	Dec. 16, 2020, 12:16 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues
```
Can you add a screenshot?
```
djblets/static/djblets/js/configForms/views/listItemView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
This needs a trailing comma.
```

Change Summary:

Added a missing trailing comma.

Commits:

	Summary	ID
	Fix the display of a pop-up menu from a configforms list item. Configforms list items with a pop-up menu action button weren't styling correctly in Djblets 2.0. We had changed the structure of pop-up menus, but didn't change the code setting up that structure. This change adds the new structure, and also fixes up some styling around the menu.	d7e7aa60e59733eb242e1dc560d78e8de9ed530c
	Fix the display of a pop-up menu from a configforms list item. Configforms list items with a pop-up menu action button weren't styling correctly in Djblets 2.0. We had changed the structure of pop-up menus, but didn't change the code setting up that structure. This change adds the new structure, and also fixes up some styling around the menu.	80207d9d1f822ebf15c30906e1b99c28955f493d

Diff:

Revision 2 (+50 -26)

Show changes

	djblets/static/djblets/css/config-forms.less
	djblets/static/djblets/js/configForms/views/listItemView.es6.js
	djblets/static/djblets/js/configForms/views/tests/listItemViewTests.es6.js

Added Files:

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (81fe429)