Rustfmt Tool for Review Bot

Review Request #11305 — Created Nov. 25, 2020 and submitted

jblazusi
ReviewBot
master
319089e...
reviewbot, students
ceciliawei

This tool is designed to be a lightweight solution capable of checking
whether a file is correctly formatted or not based on rustfmt output.

Manual testing was done to confirm that rustfmt is working correctly.


Description From Last Updated

We need to wrap this in a try/except to handle any errors.

chipx86chipx86

Can you use a keyword argument for the None value, and also put each keyword argument on its own line?

chipx86chipx86

This is a bit too vague. How about "Checks that Rust code style matches rustfmt"?

daviddavid
jblazusi
chipx86
  1. 
      
  2. bot/reviewbot/tools/rustfmt.py (Diff revision 1)
     
     
     

    We need to wrap this in a try/except to handle any errors.

  3. bot/reviewbot/tools/rustfmt.py (Diff revision 1)
     
     

    Can you use a keyword argument for the None value, and also put each keyword argument on its own line?

  4. 
      
jblazusi
jblazusi
david
  1. 
      
  2. bot/reviewbot/tools/rustfmt.py (Diff revision 3)
     
     
     

    This is a bit too vague. How about "Checks that Rust code style matches rustfmt"?

  3. 
      
jblazusi
jblazusi
david
  1. Ship It!
  2. 
      
jblazusi
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (4542a8e)
Loading...