flake8
passed.
JSHint
passed.
Rustfmt Tool for Review Bot
Review Request #11305 — Created Nov. 25, 2020 and submitted
This tool is designed to be a lightweight solution capable of checking
whether a file is correctly formatted or not based onrustfmtoutput.
Manual testing was done to confirm that
rustfmtis working correctly.
-
-
bot/reviewbot/tools/rustfmt.py (Diff revision 1) We need to wrap this in a
try/exceptto handle any errors. -
bot/reviewbot/tools/rustfmt.py (Diff revision 1) Can you use a keyword argument for the
Nonevalue, and also put each keyword argument on its own line?
Change Summary:
Addressed the comments made by Christian.
Summary: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+65) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Fixed a potential error where a variable may be undefined during execution.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+65) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
bot/reviewbot/tools/rustfmt.py (Diff revision 3) This is a bit too vague. How about "Checks that Rust code style matches rustfmt"?
Change Summary:
Addressed David's comments and updated Rustfmt Tool description.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+64) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Fixed
logger.exceptionformatting.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+64) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.