Summary

Rustfmt Tool for Review Bot

Review Request #11305 — Created Nov. 25, 2020 and submitted Jan. 15, 2021, 11:09 a.m.

Information

Owner

jblazusi

Repository

ReviewBot

Branch

master

Bugs

Depends On

Commit

319089e...

Reviewers

Groups

reviewbot, students

People

ceciliawei

Description

This tool is designed to be a lightweight solution capable of checking
whether a file is correctly formatted or not based on rustfmt output.

Testing Done

Manual testing was done to confirm that rustfmt is working correctly.

Files

Issues

Description	From	Last Updated
We need to wrap this in a try/except to handle any errors.	chipx86	Dec. 3, 2020, 6:38 p.m.
Can you use a keyword argument for the None value, and also put each keyword argument on its own line?	chipx86	Dec. 3, 2020, 6:32 p.m.
This is a bit too vague. How about "Checks that Rust code style matches rustfmt"?	david	Dec. 6, 2020, 11:38 a.m.

flake8 passed.

JSHint passed.

Change Summary:: Added picture with sample result.
Added Files:

bot/reviewbot/tools/rustfmt.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We need to wrap this in a try/except to handle any errors.
```

bot/reviewbot/tools/rustfmt.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you use a keyword argument for the None value, and also put each keyword argument on its own line?

Change Summary:

Addressed the comments made by Christian.

Summary:

Rustfmt Tool for ReviewBot

Rustfmt Tool for Review Bot

Commit:

8c3a927a56c2c65b5b0de8accd8159cb4bd6d698

6bc7d51ec1ca3f85ab7bc21a1bfe4f8d3f84ded2

Diff:

Revision 2 (+65)

Show changes

	bot/setup.py
	bot/reviewbot/tools/rustfmt.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed a potential error where a variable may be undefined during execution.

Commit:

6bc7d51ec1ca3f85ab7bc21a1bfe4f8d3f84ded2

ed205291e430b1eb0937da71d56ab10083dbbec0

Diff:

Revision 3 (+65)

Show changes

	bot/setup.py
	bot/reviewbot/tools/rustfmt.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

bot/reviewbot/tools/rustfmt.py (Diff revision 3)

The issue has been resolved. Show all issues

This is a bit too vague. How about "Checks that Rust code style matches rustfmt"?

Change Summary:

Addressed David's comments and updated Rustfmt Tool description.

Commit:

ed205291e430b1eb0937da71d56ab10083dbbec0

101a23a7702413f3831d71a0562fd0dbb9f12adf

Diff:

Revision 4 (+64)

Show changes

	bot/setup.py
	bot/reviewbot/tools/rustfmt.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed logger.exception formatting.

Commit:

101a23a7702413f3831d71a0562fd0dbb9f12adf

319089e8244881c81b182995deb43053ae36bf89

Diff:

Revision 5 (+64)

Show changes

	bot/setup.py
	bot/reviewbot/tools/rustfmt.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (4542a8e)