flake8
passed.
JSHint
passed.
Rustfmt Tool for Review Bot
Review Request #11305 — Created Nov. 25, 2020 and submitted
This tool is designed to be a lightweight solution capable of checking
whether a file is correctly formatted or not based onrustfmtoutput.
Manual testing was done to confirm that
rustfmtis working correctly.
| Description | From | Last Updated | ||
|---|---|---|---|---|
|
We need to wrap this in a try/except to handle any errors. |
 chipx86
|
|||
|
Can you use a keyword argument for the None value, and also put each keyword argument on its own line? |
chipx86
|
|||
|
This is a bit too vague. How about "Checks that Rust code style matches rustfmt"? |
 david
|
|||
| There are no open issues | ||||
- Change Summary:
-
Addressed the comments made by Christian.
- Summary:
-
Rustfmt Tool for ReviewBotRustfmt Tool for Review Bot
- Commit:
-
8c3a927a56c2c65b5b0de8accd8159cb4bd6d6986bc7d51ec1ca3f85ab7bc21a1bfe4f8d3f84ded2
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Fixed a potential error where a variable may be undefined during execution.
- Commit:
-
6bc7d51ec1ca3f85ab7bc21a1bfe4f8d3f84ded2ed205291e430b1eb0937da71d56ab10083dbbec0
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Addressed David's comments and updated Rustfmt Tool description.
- Commit:
-
ed205291e430b1eb0937da71d56ab10083dbbec0101a23a7702413f3831d71a0562fd0dbb9f12adf
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.