flake8
passed.
JSHint
passed.
Documentation for Discord Integration
Review Request #11301 — Created Nov. 24, 2020 and submitted
| Information | |
|---|---|
| hailan | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard | |
This documentation will show how users can add the Discord Integration to
their Review Board, add the appropriate configurations, and get the Discord
WebHook URL.
Looks fine in browser, but needs better screenshots.
| Summary | Author |
|---|---|
| HailanXyouknow |
| Description | From | Last Updated |
|---|---|---|
|
The actual docs look good, but can you flesh out the review request description a bit more? |
 david
|
|
|
Can we add two more = for the wrapping, i.e. having same amount of = as the title here? That … |
 ceciliawei
|
|
|
Is "dis" a typo? |
 keanweng
|
Change Summary:
remove white space
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+118) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
docs/manual/admin/integrations/discord.rst (Diff revision 2) Can we add two more
=for the wrapping, i.e. having same amount of=as the title here? That way it looks nicer.
Change Summary:
Address feedback
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+118) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Better description for this review request.
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
Change Summary:
Fix typo
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+118) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
The documentation looks clear and is in good detail! And everything makes sense to me. I only have one suggestion, not sure if the mentors agree, I think it would be nice to include your demo video one's link in the documentation, as it shows step by step of how one can setup discord integrations in video form.
