flake8
passed.
JSHint
passed.
Documentation for Discord Integration
Review Request #11301 — Created Nov. 24, 2020 and submitted
This documentation will show how users can add the Discord Integration to
their Review Board, add the appropriate configurations, and get the Discord
WebHook URL.
Looks fine in browser, but needs better screenshots.
| Summary | ID | Author |
|---|---|---|
| 797e9deaa95829e1b2ac0c565d49170e0e11e667 | HailanXyouknow |
| Description | From | Last Updated |
|---|---|---|
|
The actual docs look good, but can you flesh out the review request description a bit more? |
 david
|
|
|
Can we add two more = for the wrapping, i.e. having same amount of = as the title here? That … |
 ceciliawei
|
|
|
Is "dis" a typo? |
 keanweng
|
- Change Summary:
-
remove white space
- Commits:
-
Summary ID Author ede8c9cc68b7dae515be6899f03822af25d082f2 HailanXyouknow 46bbc22f4feb49f31e878979c31f2fe7b6884388 HailanXyouknow - Diff:
-
Revision 2 (+118)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Address feedback
- Commits:
-
Summary ID Author 46bbc22f4feb49f31e878979c31f2fe7b6884388 HailanXyouknow 08dc921069468a6dd2eccd92e41b26c25d7daa0d HailanXyouknow - Diff:
-
Revision 3 (+118)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Better description for this review request.
- Description:
-
~ Based on the documentation for Slack
~ This documentation will show how users can add the Discord Integration to
+ their Review Board, add the appropriate configurations, and get the Discord + WebHook URL. - Testing Done:
-
~ Looked at the HTML file in my browser. My images are not of the same length,
~ Looks fine in browser, but needs better screenshots.
- and the last picutre is blurry for some reason. I have not figured out why.
- Change Summary:
-
Fix typo
- Commits:
-
Summary ID Author 08dc921069468a6dd2eccd92e41b26c25d7daa0d HailanXyouknow 797e9deaa95829e1b2ac0c565d49170e0e11e667 HailanXyouknow - Diff:
-
Revision 4 (+118)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
The documentation looks clear and is in good detail! And everything makes sense to me. I only have one suggestion, not sure if the mentors agree, I think it would be nice to include your demo video one's link in the documentation, as it shows step by step of how one can setup discord integrations in video form.
