Summary

Fix Python 3 binary issues with git patch handling

Review Request #11297 — Created Nov. 23, 2020 and submitted Nov. 29, 2020, 3:26 a.m.

Owner

Repository

RBTools

Branch

master

Bugs

Depends On

Groups

People

Description

Fix Python 3 binary issues with git patch handling

Testing Done

Run rbt patch <patchno> on a Git repository with Python 3, providing a patch which does not apply properly (git returns error code != 0).

Commits

Summary	ID
Fix Python 3 binary issues with git patch handling Testing Done: Run `rbt patch <patchno>` on a Git repository with Python 3, providing a patch which does not apply properly (git returns error code != 0). Reviewed at https://reviews.reviewboard.org/r/11297/	45482a7277bfeeae243f1fb04dae09c735e84ef8
Fix one more git patch/binary issue	8ce5422e20db0ce4c48b2288f94b2498cbc2a1f2

Issues

Description	From	Last Updated
I suspect this also needs the prefix.	chipx86	Nov. 25, 2020, 4 p.m.

flake8 passed.

JSHint passed.

We're releasing tonight, but I can try to slip this in. It looks like there's one issue that I can see.

rbtools/clients/git.py (Diff revision 1)
Show all issues
```
I suspect this also needs the prefix.
```

One more minor binary-related fix.

	Summary	ID
	Fix Python 3 binary issues with git patch handling	e1ee977f30d5d70b78bf62761031601c77f4f0d6
	Fix Python 3 binary issues with git patch handling Testing Done: Run `rbt patch <patchno>` on a Git repository with Python 3, providing a patch which does not apply properly (git returns error code != 0). Reviewed at https://reviews.reviewboard.org/r/11297/	45482a7277bfeeae243f1fb04dae09c735e84ef8
	Fix one more git patch/binary issue	8ce5422e20db0ce4c48b2288f94b2498cbc2a1f2

flake8 passed.

JSHint passed.

Ship it!

Pushed to release-2.0.x (2becf39)

rbtools/clients/git.py (Diff revision 1)