Summary

Plumb through extra_data provided by diff parsers.

Review Request #11295 — Created Nov. 20, 2020 and submitted Nov. 27, 2020, 2:20 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change makes it so custom diff parsers (associated with specific
SCMTools) can provide additional extra_data to be set on the FileDiff.
This change does the plumbing to take the extra_data from the parser and
store it in the database.

Testing Done

Used in conjunction with other changes.

Commits

Summary	ID
Plumb through extra_data provided by diff parsers. This change makes it so custom diff parsers (associated with specific SCMTools) can provide additional extra_data to be set on the FileDiff. This change does the plumbing to take the extra_data from the parser and store it in the database. Testing Done: - Ran unit tests. - Used in conjunction with other changes.	d06640b5ac05161e01127fea01fc99d5023d0115

Issues

Description	From	Last Updated
Can you add a unit test? (That's the bit I never got around to when originally working on this stuff.)	chipx86	Nov. 24, 2020, 2:54 p.m.
""" on the next line.	chipx86	Nov. 27, 2020, 11:56 a.m.
Leftover debugging?	chipx86	Nov. 27, 2020, 11:56 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you add a unit test? (That's the bit I never got around to when originally working on this stuff.)

Change Summary:

Add tests.

Commits:

	Summary	ID
	Plumb through extra_data provided by diff parsers. This change makes it so custom diff parsers (associated with specific SCMTools) can provide additional extra_data to be set on the FileDiff. This change does the plumbing to take the extra_data from the parser and store it in the database. Testing Done: Used in conjunction with other changes.	8766e2410c4da20ab8a4a8d0e2a6a711a2981568
	Plumb through extra_data provided by diff parsers. This change makes it so custom diff parsers (associated with specific SCMTools) can provide additional extra_data to be set on the FileDiff. This change does the plumbing to take the extra_data from the parser and store it in the database. Testing Done: - Ran unit tests. - Used in conjunction with other changes.	d06640b5ac05161e01127fea01fc99d5023d0115

Diff:

Revision 2 (+150 -6)

Show changes

	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/parser.py
	reviewboard/diffviewer/tests/test_diff_parser.py
	reviewboard/diffviewer/tests/test_diffset_manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/diffviewer/tests/test_diffset_manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
""" on the next line.
```
reviewboard/diffviewer/tests/test_diffset_manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Leftover debugging?
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (d6b9874)