Add a RuboCop tool for ReviewBot.

Review Request #11291 — Created Nov. 19, 2020 and submitted

Information

ReviewBot
master

Reviewers

This adds support for RuboCop through Review Bot. RuboCop is a Ruby
static code analyzer and formatter, based on the community Ruby
style guide.

Configured the tool and ran it manually.

Summary ID Author
Add a RuboCop tool for ReviewBot.
d501e946ce06b127628f077a84d788d0de6f2c1f ceciliaccwei

Description From Last Updated

The execute function should be placed inside of a try/except.

jblazusijblazusi

Same as before, the execute function should be placed inside of a try/except.

jblazusijblazusi
ceciliawei
ceciliawei
hailan
  1. Great job
  2. 
      
jblazusi
  1. Ship It!
  2. 
      
jblazusi
  1. I have noticed that this is not something that is being checked in other Review Bot Tools. However, David has told me that this will change and that the mentors would like for the execute method to be in a try/except in all tools eventually.

  2. bot/reviewbot/tools/rubocop.py (Diff revision 2)
     
     

    The execute function should be placed inside of a try/except.

  3. bot/reviewbot/tools/rubocop.py (Diff revision 2)
     
     

    Same as before, the execute function should be placed inside of a try/except.

  4. 
      
ceciliawei
david
  1. Ship It!
  2. 
      
ceciliawei
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (21dbad8)
Loading...