Add a RuboCop tool for ReviewBot.

Review Request #11291 — Created Nov. 19, 2020 and submitted

Information
ceciliawei
ReviewBot
master
Reviewers
reviewbot, students
jblazusi 
This adds support for RuboCop through Review Bot. RuboCop is a Ruby

static code analyzer and formatter, based on the community Ruby

style guide.
Configured the tool and ran it manually.
Summary Author 
Add a RuboCop tool for ReviewBot.
 ceciliaccwei

Description From Last Updated

The execute function should be placed inside of a try/except.

 jblazusijblazusi

Same as before, the execute function should be placed inside of a try/except.

 jblazusijblazusi
ceciliawei
ceciliawei
hailan
hailan 
  1. Great job
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




jblazusi




   

   







  

 



 

  


   

   

    
 
jblazusi


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




jblazusi




   

   







  

 



 

  


   

   

    
 
jblazusi


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I have noticed that this is not something that is being checked in other Review Bot Tools. However, David has told me that this will change and that the mentors would like for the execute method to be in a try/except in all tools eventually.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      bot/reviewbot/tools/rubocop.py
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    The execute function should be placed inside of a try/except.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      bot/reviewbot/tools/rubocop.py
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Same as before, the execute function should be placed inside of a try/except.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




ceciliawei




   

   

  

 



 















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




ceciliawei




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-2.0.x (21dbad8)





 


 










  

 









     

    

   

  

  

   
   Loading...