flake8
passed.
JSHint
passed.
Add a RuboCop tool for ReviewBot.
Review Request #11291 — Created Nov. 19, 2020 and submitted
This adds support for RuboCop through Review Bot. RuboCop is a Ruby
static code analyzer and formatter, based on the community Ruby
style guide.
Configured the tool and ran it manually.
Change Summary:
Added documentation.
Commits: |
|
||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+230) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
I have noticed that this is not something that is being checked in other Review Bot Tools. However, David has told me that this will change and that the mentors would like for the
executemethod to be in a try/except in all tools eventually. -
bot/reviewbot/tools/rubocop.py (Diff revision 2) The
executefunction should be placed inside of a try/except. -
bot/reviewbot/tools/rubocop.py (Diff revision 2) Same as before, the
executefunction should be placed inside of a try/except.
Change Summary:
Addressed feedback.
Commits: |
|
||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+242) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
