Summary

Add a RuboCop tool for ReviewBot.

Review Request #11291 — Created Nov. 19, 2020 and submitted Jan. 18, 2021, 2:08 p.m.

Information

Owner

ceciliawei

Repository

ReviewBot

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewbot, students

People

jblazusi

Description

This adds support for RuboCop through Review Bot. RuboCop is a Ruby

static code analyzer and formatter, based on the community Ruby

style guide.

Testing Done

Configured the tool and ran it manually.

Commits

Summary	ID	Author
Add a RuboCop tool for ReviewBot.	d501e946ce06b127628f077a84d788d0de6f2c1f	ceciliaccwei

Files

Issues

Description	From	Last Updated
The execute function should be placed inside of a try/except.	jblazusi	Dec. 6, 2020, 9:11 p.m.
Same as before, the execute function should be placed inside of a try/except.	jblazusi	Dec. 6, 2020, 9:11 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Added documentation.

Commits:

	Summary	ID	Author
	Add a RuboCop tool for ReviewBot.	3c311b178667cc476ac94a549154f3f3f74e96be	ceciliaccwei
	Add a RuboCop tool for ReviewBot.	d32aaa4e8015aa90f0645357741b4ca1ced5fc63	ceciliaccwei

Diff:

Revision 2 (+230)

Show changes

	bot/setup.py
	bot/reviewbot/tools/rubocop.py
	docs/reviewbot/tools/index.rst
	docs/reviewbot/tools/rubocop.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Added Files:

Ship it!

```
Great job
```

Ship it!

```
Ship It!
```

I have noticed that this is not something that is being checked in other Review Bot Tools. However, David has told me that this will change and that the mentors would like for the execute method to be in a try/except in all tools eventually.

bot/reviewbot/tools/rubocop.py (Diff revision 2)
The issue has been resolved. Show all issues
```
The execute function should be placed inside of a try/except.
```
bot/reviewbot/tools/rubocop.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same as before, the execute function should be placed inside of a try/except.
```

Change Summary:

Addressed feedback.

Commits:

	Summary	ID	Author
	Add a RuboCop tool for ReviewBot.	d32aaa4e8015aa90f0645357741b4ca1ced5fc63	ceciliaccwei
	Add a RuboCop tool for ReviewBot.	d501e946ce06b127628f077a84d788d0de6f2c1f	ceciliaccwei

Diff:

Revision 3 (+242)

Show changes

	bot/setup.py
	bot/reviewbot/tools/rubocop.py
	docs/reviewbot/tools/index.rst
	docs/reviewbot/tools/rubocop.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (21dbad8)