Pass through FileDiff extra_data into filename normalization.

Review Request #11282 — Created Nov. 16, 2020 and submitted

david
Review Board
release-3.0.x
reviewboard

While most version control systems are relatively sane and treat a
filename as a filename, there are a few that don't. We first encountered
this with CVS, which loves to add a ,v to the end of filenames
depending on the method of access. To address this, we added a
normalization method that SCMTools could override.

Impending work on improving support for ClearCase requires even fancier
normalization, and one that requires being able to use some data about
the repository. This change adds the FileDiff extra_data as an argument
to the normalization method.

This is a soft API break. Existing SCMTools which provide a normalize
method that does not take any additional arguments will continue to
function, but emit a deprecation warning.

Ran unit tests.

Summary
Pass through FileDiff extra_data into filename normalization.
Description From Last Updated

F841 local variable 'diff_files' is assigned to but never used

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (d53fc2d)
Loading...