Fix issues testing rbt with the right environment.

Review Request #11275 — Created Nov. 13, 2020 and submitted

Information

RBTools
release-2.0.x

Reviewers

The unit tests for the rbt command weren't always running the correct
version of RBTools. The main test suite was running whatever rbt was
in the path with whatever version of Python it was installed with, which
didn't guarantee correct results, while the --version tests ran with
the current Python but also ran the first build found in the path.

These could produce wrong results, and in fact have in my own test
environment. To fix this, we now run the bundled copy specifically, and
we now always do so with the current version of Python. This ensures a
reliable test run, and also allows us to consolidate the two test suites
for this command.

Unit tests pass.

Summary ID
Fix issues testing rbt with the right environment.
The unit tests for the `rbt` command weren't always running the correct version of RBTools. The main test suite was running whatever `rbt` was in the path with whatever version of Python it was installed with, which didn't guarantee correct results, while the `--version` tests ran with the current Python but also ran the first build found in the path. These could produce wrong results, and in fact have in my own test environment. To fix this, we now run the bundled copy specifically, and we now always do so with the current version of Python. This ensures a reliable test run, and also allows us to consolidate the two test suites for this command.
60503451a68a3ecfd3da11d382f505f7bd710418
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (ac663b3)
Loading...