Summary

Add compatibility with Python 3.9.

Review Request #11270 — Created Nov. 8, 2020 and submitted Nov. 11, 2020, 11:23 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Python 3.9 removed a couple of deprecated functions/arguments that we
used, which was the only thing preventing us from claiming Python 3.9
support.

This change updates our usage of json.loads() to not pass an
encoding= argument (removed in Python 3.9) and to instead handle
decoding byte strings up-front, and to update unit tests to not depend
on an internal, deprecated method on HTMLParser.

setup.py has been updated to reflect the current supported list of
Python versions.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add compatibility with Python 3.9. Python 3.9 removed a couple of deprecated functions/arguments that we used, which was the only thing preventing us from claiming Python 3.9 support. This change updates our usage of `json.loads()` to not pass an `encoding=` argument (removed in Python 3.9) and to instead handle decoding byte strings up-front, and to update unit tests to not depend on an internal, deprecated method on `HTMLParser`.	995541a256c5210e50ca22d5052933e07a1683b0

Summary

Add compatibility with Python 3.9.

Python 3.9 removed a couple of deprecated functions/arguments that we used, which was the only thing preventing us from claiming Python 3.9 support. This change updates our usage of `json.loads()` to not pass an `encoding=` argument (removed in Python 3.9) and to instead handle decoding byte strings up-front, and to update unit tests to not depend on an internal, deprecated method on `HTMLParser`.

995541a256c5210e50ca22d5052933e07a1683b0

Issues

Description	From	Last Updated
Is this really something that can happen? It seems like if we had double-encoded JSON, once it's in unicode, loadsing …	david	Nov. 10, 2020, 12:39 p.m.

flake8 passed.

JSHint passed.

djblets/db/fields/json_field.py (Diff revision 1)

The issue has been resolved. Show all issues

Is this really something that can happen? It seems like if we had double-encoded JSON, once it's in unicode, loadsing it should stay in unicode.

chipx86 Nov. 9, 2020, 4:54 p.m.

Probably. I was just keeping the same logic. I'll change it.

Change Summary:

Removed a probably-unnecessary second pass of the handling of encodings when JSON deserialization results in a string.

Commits:

	Summary	ID
	Add compatibility with Python 3.9. Python 3.9 removed a couple of deprecated functions/arguments that we used, which was the only thing preventing us from claiming Python 3.9 support. This change updates our usage of `json.loads()` to not pass an `encoding=` argument (removed in Python 3.9) and to instead handle decoding byte strings up-front, and to update unit tests to not depend on an internal, deprecated method on `HTMLParser`.	6104ebbf5167c4d47819669a305f51ebbb7fb4c1
	Add compatibility with Python 3.9. Python 3.9 removed a couple of deprecated functions/arguments that we used, which was the only thing preventing us from claiming Python 3.9 support. This change updates our usage of `json.loads()` to not pass an `encoding=` argument (removed in Python 3.9) and to instead handle decoding byte strings up-front, and to update unit tests to not depend on an internal, deprecated method on `HTMLParser`.	995541a256c5210e50ca22d5052933e07a1683b0

Diff:

Revision 2 (+210 -388)

Show changes

	setup.py
	djblets/db/fields/json_field.py
	djblets/util/tests/test_djblets_utils_tags.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (dde5b99)