Summary

Add manual trigger run and retry for TravisCI integration.

Review Request #11266 — Created Nov. 5, 2020 and submitted Aug. 27, 2021, 2:35 p.m.

Information

Owner

MarcusBoay

Repository

rbintegrations

Branch

master

Bugs

Depends On

Reviewers

Groups

rbintegrations

People

Description

Add manual trigger to TravisCI.
This change adds the ability for Integrations to run TravisCI manually.

A checkbox is added to the TravisCI form that indicates if TravisCI should

only run manually.
This change also fixes the Jenkins build failing for git repositories with less

than 50 commits since git fetch --unshallow origin fails.
There was a bug where no TravisCI builds can be made on personal private GitHub

repositories because the GitHub username was being extracted from the wrong place.
Based on work by David Trowbridge: /r/11130

Testing Done

Manually tested on Review Board 3. TravisCI (travis-ci.com) was set up and 

connected to a private GitHub repository and Review Board 3. A TravisCI build

was not run when the manually run checkbox is unchecked and is run when the

field is checked. Clicking on the 'Run' button runs the TravisCI build.
Verified the disabled/enabled run manually field by testing on Review Board

3.0.18, 3.0.19 and 4.0.x.
Verified retry functionality when state is in ERROR and TIMEOUT states.
Unit tests to verify that a build is not run when the run manually

configuration is checked and to verify that a build is run when the signal is

emitted.
Unit tests were also created to verify that the username is being pulled

from the correct place for the 4 different GitHub repository plans.

These were ran on Review Board 3.0 and Review Board 4.0 and their

supported versions of Python.

Commits

Summary	ID
Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	7727980671a8ce70a5a714944178a8c9acd1a277

Issues

Description	From	Last Updated
W293 blank line contains whitespace	reviewbot	Nov. 5, 2020, 1:29 a.m.
We typically put things like this at the end of the relevant block of imports, rather than trying to keep …	david	Nov. 24, 2020, 6:02 p.m.
I think that there should be a period at the end of this comment.	jblazusi	Dec. 3, 2020, 1:55 a.m.
Similarly, I think that there should be a period at the end of this comment.	jblazusi	Dec. 3, 2020, 1:56 a.m.
I believe this """ should be on the next line.	jblazusi	Dec. 3, 2020, 1:57 a.m.
I believe this """ should be on the next line.	jblazusi	Dec. 3, 2020, 1:57 a.m.
I believe this """ should be on the next line.	jblazusi	Dec. 3, 2020, 1:57 a.m.
I believe this """ should be on the next line.	jblazusi	Dec. 3, 2020, 1:57 a.m.
Please remove the period at the end of this docstring, since the test runner will append an ellipsis.	david	Dec. 4, 2020, 2:11 a.m.
Same here.	david	Dec. 4, 2020, 2:12 a.m.
Same here.	david	Dec. 4, 2020, 2:12 a.m.
Same here.	david	Dec. 4, 2020, 2:12 a.m.
Same here.	david	Dec. 4, 2020, 2:12 a.m.
The grammar is funky here, but more importantly, I'm not sure we need this comment. This text seems to be …	david	Dec. 12, 2020, 7:21 a.m.

flake8 failed.

JSHint passed.

flake8

rbintegrations/jenkinsci/api.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```

Description:

~		Add manual trigger to JenkinsCI.
	~	Add manual trigger to TravisCI.

		This change adds the ability for Integrations to run TravisCI manually.
~		A checkbox is added to the JenkinsCI form that indicates if TravisCI should
	~	A checkbox is added to the TravisCI form that indicates if TravisCI should
		only run manually.

~		This change also fixes the Jenkins API failing for git repositories with less
	~	This change also fixes the Jenkins build failing for git repositories with less
		than 50 commits since `git fetch --unshallow origin` fails.

		Based on work by David Trowbridge: /r/11130

Commits:

	Summary	ID
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	8a68d8a800fec1e5e76ba69452adff747dc65531
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	e4e8e070d8180361f0a346b994a7acd18a0b8c4e

Diff:

Revision 2 (+846 -268)

Show changes

	rbintegrations/travisci/forms.py
	rbintegrations/travisci/integration.py
	rbintegrations/travisci/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		Add manual trigger to TravisCI.

		This change adds the ability for Integrations to run TravisCI manually.
		A checkbox is added to the TravisCI form that indicates if TravisCI should
		only run manually.

		This change also fixes the Jenkins build failing for git repositories with less
		than 50 commits since `git fetch --unshallow origin` fails.

	+	There was a bug where personal private GitHub repositories because the GitHub
	+	username was being extracted from the wrong place.
	+
		Based on work by David Trowbridge: /r/11130

Testing Done:

		Manually tested on Review Board 3. TravisCI (travis-ci.com) was set up and
		connected to a private GitHub repository and Review Board 3. A TravisCI build
		was not run when the manually run checkbox is unchecked and is run when the
		field is checked. Clicking on the 'Run' button runs the TravisCI build.

		Verified the disabled/enabled run manually field by testing on Review Board
		3.0.18, 3.0.19 and 4.0.x.

		Verified retry functionality when state is in ERROR and TIMEOUT states.

		Unit tests to verify that a build is not run when the run manually
		configuration is checked and to verify that a build is run when the signal is
		emitted.
	+
	+	Unit tests were also created to verify that the username is being pulled
	+	from the correct place for the 4 different GitHub repository plans.
	+	These were ran on Review Board 3.0 and Review Board 4.0 and their
	+	supported versions of Python.

Description:

		Add manual trigger to TravisCI.

		This change adds the ability for Integrations to run TravisCI manually.
		A checkbox is added to the TravisCI form that indicates if TravisCI should
		only run manually.

		This change also fixes the Jenkins build failing for git repositories with less
		than 50 commits since `git fetch --unshallow origin` fails.

~		There was a bug where personal private GitHub repositories because the GitHub
~		username was being extracted from the wrong place.
	~	There was a bug where no TravisCI builds can be made on personal private GitHub
	~	repositories because the GitHub username was being extracted from the wrong place.

		Based on work by David Trowbridge: /r/11130

rbintegrations/travisci/forms.py (Diff revision 2)

Show all issues

We typically put things like this at the end of the relevant block of imports, rather than trying to keep it alphabetical (that's because it's kind of special, and the multiple-lines makes it so we can't automatically sort them anymore)

Change Summary:

Move try except import to end of block

Commits:

	Summary	ID
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	e4e8e070d8180361f0a346b994a7acd18a0b8c4e
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	3e834fcf3a2f97d8d1686304599c588af678003e

Diff:

Revision 3 (+846 -268)

Show changes

	rbintegrations/travisci/forms.py
	rbintegrations/travisci/integration.py
	rbintegrations/travisci/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Looks good, just found some nit picks regarding the styling on the comments. I am not 100% certain about all of them. So perhaps the mentors could verify.

rbintegrations/travisci/forms.py (Diff revision 3)

Show all issues

I think that there should be a period at the end of this comment.

rbintegrations/travisci/integration.py (Diff revision 3)

Show all issues

Similarly, I think that there should be a period at the end of this comment.

rbintegrations/travisci/tests.py (Diff revision 3)
Show all issues
```
I believe this """ should be on the next line.
```
rbintegrations/travisci/tests.py (Diff revision 3)
Show all issues
```
I believe this """ should be on the next line.
```
rbintegrations/travisci/tests.py (Diff revision 3)
Show all issues
```
I believe this """ should be on the next line.
```
rbintegrations/travisci/tests.py (Diff revision 3)
Show all issues
```
I believe this """ should be on the next line.
```

Change Summary:

Adjust docstrings

Commits:

	Summary	ID
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	3e834fcf3a2f97d8d1686304599c588af678003e
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	e595af6d69e61cb821ce42ccec1ae3ccc7655e6c

Diff:

Revision 4 (+854 -268)

Show changes

	rbintegrations/travisci/forms.py
	rbintegrations/travisci/integration.py
	rbintegrations/travisci/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbintegrations/travisci/tests.py (Diff revision 4)

Show all issues

Please remove the period at the end of this docstring, since the test runner will append an ellipsis.

rbintegrations/travisci/tests.py (Diff revision 4)
Show all issues
```
Same here.
```
rbintegrations/travisci/tests.py (Diff revision 4)
Show all issues
```
Same here.
```
rbintegrations/travisci/tests.py (Diff revision 4)
Show all issues
```
Same here.
```
rbintegrations/travisci/tests.py (Diff revision 4)
Show all issues
```
Same here.
```

Change Summary:

Removed period at the end of docstrings for tests

Commits:

	Summary	ID
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	e595af6d69e61cb821ce42ccec1ae3ccc7655e6c
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	cc537902080fcccf4633797f205ef19a829ab0df

Diff:

Revision 5 (+854 -268)

Show changes

	rbintegrations/travisci/forms.py
	rbintegrations/travisci/integration.py
	rbintegrations/travisci/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbintegrations/travisci/integration.py (Diff revision 5)

Show all issues

The grammar is funky here, but more importantly, I'm not sure we need this comment. This text seems to be modeled on the previously-existing comment about review requests lacking diffs, but I'm not sure it adds useful information. The matching configs are literally what will get built--this isn't a filtering step in the way that the check for diffs is.

Other than the issue David mentioned above, everything looks good to me.

Change Summary:

Remove extraneous comment

Commits:

	Summary	ID
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	cc537902080fcccf4633797f205ef19a829ab0df
	Add manual trigger to TravisCI. Add unit tests for TravisCI manual trigger.	7727980671a8ce70a5a714944178a8c9acd1a277

Diff:

Revision 6 (+852 -268)

Show changes

	rbintegrations/travisci/forms.py
	rbintegrations/travisci/integration.py
	rbintegrations/travisci/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (5d6e94f)