[WIP] Implemented review feedback and expanded on structure of the testing suite

Review Request #11256 — Created Oct. 29, 2020 and discarded

Information

ReviewBot
master

Reviewers

Fixed comment length (changed to 70 characters)

Added .nosids and .test_notes to .gitignore (Note: I'm hoping I did it properly. I may have only added the file name and not a path so please let me know if I messed up).

Moved all subclasses from the previous runtests.py file into their own files.

Added more empty function definitions in the new files that match the tests I have planned for that file.

Also, I'm assuming I'm going to have flake8 errors again. I'm not exactly sure how to execute "flake8 --ignore E121,E125,E129,E241 --max-line-length 79 PATH" locally as it gives me an error in my terminal. If anyone knows what I'm doing wrong please let me know.


 
jace
jace
jace
ceciliawei
  1. 
      
  2. 
      
david
Review request changed

Status: Discarded

Loading...