[WIP] oauth slack

Review Request #11255 — Created Nov. 1, 2020 and discarded

Information

rbintegrations
master

Reviewers

[WIP] oauth slack

 
Summary ID Author
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
fix lint
4bc7677d9c8a060a9f66edb6e5d70bdaf373ff5b ruonan
fix lint
649828ce017b70c34262d401d61109db087c9f41 ruonan
fix lint
6ad6d1f4a4fa428c36529f7b2b184d68c373d784 ruonan
Description From Last Updated

F401 'django.conf.settings' imported but unused

reviewbotreviewbot

F401 'django.utils.html.format_html' imported but unused

reviewbotreviewbot

E501 line too long (147 > 79 characters)

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

E114 indentation is not a multiple of four (comment)

reviewbotreviewbot

E116 unexpected indentation (comment)

reviewbotreviewbot

E114 indentation is not a multiple of four (comment)

reviewbotreviewbot

E116 unexpected indentation (comment)

reviewbotreviewbot

E114 indentation is not a multiple of four (comment)

reviewbotreviewbot

E116 unexpected indentation (comment)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused

reviewbotreviewbot

F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused

reviewbotreviewbot

F401 'reviewboard.integrations.base.get_integration_manager' imported but unused

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

Col: 10 'authorize' is defined but never used.

reviewbotreviewbot

Col: 68 Missing semicolon.

reviewbotreviewbot

Col: 60 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

F401 'django.conf.settings' imported but unused

reviewbotreviewbot

F401 'django.utils.html.format_html' imported but unused

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E231 missing whitespace after ':'

reviewbotreviewbot

F401 'requests' imported but unused

reviewbotreviewbot

F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused

reviewbotreviewbot

F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused

reviewbotreviewbot

F401 'reviewboard.integrations.base.get_integration_manager' imported but unused

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W391 blank line at end of file

reviewbotreviewbot

Col: 69 Missing semicolon.

reviewbotreviewbot

Col: 10 'authorize' is defined but never used.

reviewbotreviewbot

Col: 68 Missing semicolon.

reviewbotreviewbot

Col: 60 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

Col: 76 Missing semicolon.

reviewbotreviewbot

Col: 45 Missing semicolon.

reviewbotreviewbot

Col: 47 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 48 Missing semicolon.

reviewbotreviewbot

Col: 52 Missing semicolon.

reviewbotreviewbot

Col: 67 Missing semicolon.

reviewbotreviewbot

Col: 47 Missing semicolon.

reviewbotreviewbot

Col: 43 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 47 Expected '{' and instead saw 'return'.

reviewbotreviewbot

Col: 39 Expected '===' and instead saw '=='.

reviewbotreviewbot

Col: 46 Missing semicolon.

reviewbotreviewbot

Col: 10 'gup' was used before it was defined.

reviewbotreviewbot

Col: 17 Missing semicolon.

reviewbotreviewbot

F401 'django.conf.settings' imported but unused

reviewbotreviewbot

F401 'django.utils.html.format_html' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E231 missing whitespace after ':'

reviewbotreviewbot

F401 'requests' imported but unused

reviewbotreviewbot

F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused

reviewbotreviewbot

F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused

reviewbotreviewbot

F401 'reviewboard.integrations.base.get_integration_manager' imported but unused

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

Col: 10 'authorize' is defined but never used.

reviewbotreviewbot

Col: 68 Missing semicolon.

reviewbotreviewbot

Col: 68 Missing semicolon.

reviewbotreviewbot

Col: 60 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

Col: 76 Missing semicolon.

reviewbotreviewbot

Col: 45 Missing semicolon.

reviewbotreviewbot

Col: 47 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 48 Missing semicolon.

reviewbotreviewbot

Col: 52 Missing semicolon.

reviewbotreviewbot

Col: 67 Missing semicolon.

reviewbotreviewbot

Col: 47 Missing semicolon.

reviewbotreviewbot

Col: 43 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 47 Expected '{' and instead saw 'return'.

reviewbotreviewbot

Col: 39 Expected '===' and instead saw '=='.

reviewbotreviewbot

Col: 48 Missing semicolon.

reviewbotreviewbot

Col: 10 'gup' was used before it was defined.

reviewbotreviewbot

Col: 17 Missing semicolon.

reviewbotreviewbot

Col: 10 'authorize' is defined but never used.

reviewbotreviewbot

Col: 68 Missing semicolon.

reviewbotreviewbot

Col: 68 Missing semicolon.

reviewbotreviewbot

Col: 60 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

Col: 76 Missing semicolon.

reviewbotreviewbot

Col: 45 Missing semicolon.

reviewbotreviewbot

Col: 47 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 48 Missing semicolon.

reviewbotreviewbot

Col: 52 Missing semicolon.

reviewbotreviewbot

Col: 67 Missing semicolon.

reviewbotreviewbot

Col: 47 Missing semicolon.

reviewbotreviewbot

Col: 43 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 47 Expected '{' and instead saw 'return'.

reviewbotreviewbot

Col: 39 Expected '===' and instead saw '=='.

reviewbotreviewbot

Col: 48 Missing semicolon.

reviewbotreviewbot

Col: 10 'gup' was used before it was defined.

reviewbotreviewbot

Col: 17 Missing semicolon.

reviewbotreviewbot

Col: 10 'authorize' is defined but never used.

reviewbotreviewbot

Col: 47 Missing semicolon.

reviewbotreviewbot

Col: 43 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 47 Expected '{' and instead saw 'return'.

reviewbotreviewbot

Col: 39 Expected '===' and instead saw '=='.

reviewbotreviewbot

Col: 48 Missing semicolon.

reviewbotreviewbot

Col: 10 'gup' was used before it was defined.

reviewbotreviewbot

Col: 10 'authorize' is defined but never used.

reviewbotreviewbot

Col: 47 Missing semicolon.

reviewbotreviewbot

Col: 43 Expected '!==' and instead saw '!='.

reviewbotreviewbot

Col: 47 Expected '{' and instead saw 'return'.

reviewbotreviewbot

Col: 39 Expected '===' and instead saw '=='.

reviewbotreviewbot

Col: 48 Missing semicolon.

reviewbotreviewbot

Col: 10 'gup' was used before it was defined.

reviewbotreviewbot

Col: 10 'authorize' is defined but never used.

reviewbotreviewbot

Col: 39 Expected '===' and instead saw '=='.

reviewbotreviewbot

Col: 48 Missing semicolon.

reviewbotreviewbot

Col: 10 'authorize' is defined but never used.

reviewbotreviewbot
Checks run (2 failed)
flake8 failed.
JSHint failed.

flake8

JSHint

ruonanjia
ruonanjia
Review request changed
Commits:
Summary ID Author
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan

Checks run (2 failed)

flake8 failed.
JSHint failed.

flake8

JSHint

ruonanjia
Review request changed
Commits:
Summary ID Author
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan

Checks run (2 failed)

flake8 failed.
JSHint failed.

flake8

JSHint

ruonanjia
Review request changed
Commits:
Summary ID Author
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

ruonanjia
Review request changed
Commits:
Summary ID Author
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
fix lint
4bc7677d9c8a060a9f66edb6e5d70bdaf373ff5b ruonan

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

ruonanjia
Review request changed
Commits:
Summary ID Author
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
fix lint
4bc7677d9c8a060a9f66edb6e5d70bdaf373ff5b ruonan
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
fix lint
4bc7677d9c8a060a9f66edb6e5d70bdaf373ff5b ruonan

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

ruonanjia
Review request changed
Commits:
Summary ID Author
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
fix lint
4bc7677d9c8a060a9f66edb6e5d70bdaf373ff5b ruonan
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
fix lint
4bc7677d9c8a060a9f66edb6e5d70bdaf373ff5b ruonan
fix lint
649828ce017b70c34262d401d61109db087c9f41 ruonan

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

ruonanjia
Review request changed
Commits:
Summary ID Author
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
fix lint
4bc7677d9c8a060a9f66edb6e5d70bdaf373ff5b ruonan
fix lint
649828ce017b70c34262d401d61109db087c9f41 ruonan
[WIP] oauth slack
94fbe56e8ad34c9b8a50db95837feec0f2c5f910 ruonan
[WIP] slack oauth
9aaed7c2af13df6a1c34fae09ba03a8b2d85c039 ruonan
[WIP] Slack oauth
1ae7d35d1e99b6d28b0f77ce9de0251332160484 ruonan
[WIP] Slack Integration
e865d07f85fab8f48817592d85fda2e2a57bb14e ruonan
Slack Oauth Integration
bd6933d0fa08d5257046f2d6a03cc0a32f993cc1 ruonan
fix lint
826d4aecc2079f38d45b1cac9e650f158f365afd ruonan
fix lint
4bc7677d9c8a060a9f66edb6e5d70bdaf373ff5b ruonan
fix lint
649828ce017b70c34262d401d61109db087c9f41 ruonan
fix lint
6ad6d1f4a4fa428c36529f7b2b184d68c373d784 ruonan

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

ruonanjia
Review request changed
Status:
Discarded