- Download Diff

Summary:

[WIP] oauth slack

Review Request #11255 — Created Nov. 1, 2020 and discarded Nov. 19, 2020, 12:34 a.m.

Information
Owner:	ruonanjia
Repository:	rbintegrations
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	rbintegrations, students
People:

Description

[WIP] oauth slack

Testing Done

Commits

Summary	Author
[WIP] oauth slack	ruonan
[WIP] slack oauth	ruonan
[WIP] Slack oauth	ruonan
[WIP] Slack Integration	ruonan
Slack Oauth Integration	ruonan
fix lint	ruonan
fix lint	ruonan
fix lint	ruonan
fix lint	ruonan

Screenshots

Issues

Description	From	Last Updated
F401 'django.conf.settings' imported but unused	reviewbot	Nov. 1, 2020, 2:19 p.m.
F401 'django.utils.html.format_html' imported but unused	reviewbot	Nov. 1, 2020, 2:19 p.m.
E501 line too long (147 > 79 characters)	reviewbot	Nov. 1, 2020, 2:19 p.m.
W292 no newline at end of file	reviewbot	Nov. 1, 2020, 2:19 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 1, 2020, 2:19 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 1, 2020, 2:19 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 1, 2020, 2:19 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 1, 2020, 2:19 p.m.
E265 block comment should start with '# '	reviewbot	Nov. 1, 2020, 2:19 p.m.
E114 indentation is not a multiple of four (comment)	reviewbot	Nov. 1, 2020, 2:19 p.m.
E116 unexpected indentation (comment)	reviewbot	Nov. 1, 2020, 2:19 p.m.
E114 indentation is not a multiple of four (comment)	reviewbot	Nov. 1, 2020, 2:19 p.m.
E116 unexpected indentation (comment)	reviewbot	Nov. 1, 2020, 2:19 p.m.
E114 indentation is not a multiple of four (comment)	reviewbot	Nov. 1, 2020, 2:19 p.m.
E116 unexpected indentation (comment)	reviewbot	Nov. 1, 2020, 2:19 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 1, 2020, 2:19 p.m.
F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused	reviewbot	Nov. 1, 2020, 2:19 p.m.
F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused	reviewbot	Nov. 1, 2020, 2:19 p.m.
F401 'reviewboard.integrations.base.get_integration_manager' imported but unused	reviewbot	Nov. 1, 2020, 2:19 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 1, 2020, 2:19 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 1, 2020, 2:19 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 1, 2020, 2:19 p.m.
Col: 10 'authorize' is defined but never used.	reviewbot	Nov. 1, 2020, 2:19 p.m.
Col: 68 Missing semicolon.	reviewbot	Nov. 1, 2020, 2:19 p.m.
Col: 60 Missing semicolon.	reviewbot	Nov. 1, 2020, 2:19 p.m.
Col: 62 Missing semicolon.	reviewbot	Nov. 1, 2020, 2:19 p.m.
F401 'django.conf.settings' imported but unused	reviewbot	Nov. 12, 2020, 9:27 p.m.
F401 'django.utils.html.format_html' imported but unused	reviewbot	Nov. 12, 2020, 9:27 p.m.
W292 no newline at end of file	reviewbot	Nov. 12, 2020, 9:27 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 12, 2020, 9:27 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Nov. 12, 2020, 9:27 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 12, 2020, 9:27 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 12, 2020, 9:27 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W291 trailing whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W291 trailing whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W291 trailing whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W291 trailing whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W291 trailing whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W291 trailing whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 12, 2020, 9:27 p.m.
E231 missing whitespace after ':'	reviewbot	Nov. 12, 2020, 9:27 p.m.
F401 'requests' imported but unused	reviewbot	Nov. 12, 2020, 9:27 p.m.
F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused	reviewbot	Nov. 12, 2020, 9:27 p.m.
F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused	reviewbot	Nov. 12, 2020, 9:27 p.m.
F401 'reviewboard.integrations.base.get_integration_manager' imported but unused	reviewbot	Nov. 12, 2020, 9:27 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Nov. 12, 2020, 9:27 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 12, 2020, 9:27 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2020, 9:27 p.m.
W391 blank line at end of file	reviewbot	Nov. 12, 2020, 9:27 p.m.
Col: 69 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 10 'authorize' is defined but never used.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 68 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 60 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 62 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 76 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 45 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 47 Expected '!==' and instead saw '!='.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 48 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 52 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 67 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 47 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 43 Expected '!==' and instead saw '!='.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 47 Expected '{' and instead saw 'return'.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 46 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 10 'gup' was used before it was defined.	reviewbot	Nov. 12, 2020, 9:26 p.m.
Col: 17 Missing semicolon.	reviewbot	Nov. 12, 2020, 9:26 p.m.
F401 'django.conf.settings' imported but unused	reviewbot	Nov. 18, 2020, 9:59 p.m.
F401 'django.utils.html.format_html' imported but unused	reviewbot	Nov. 18, 2020, 9:59 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2020, 9:59 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Nov. 18, 2020, 9:59 p.m.
W292 no newline at end of file	reviewbot	Nov. 18, 2020, 9:59 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2020, 9:59 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Nov. 18, 2020, 9:59 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 18, 2020, 9:59 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Nov. 18, 2020, 9:59 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 18, 2020, 9:59 p.m.
E231 missing whitespace after ':'	reviewbot	Nov. 18, 2020, 9:59 p.m.
F401 'requests' imported but unused	reviewbot	Nov. 18, 2020, 9:59 p.m.
F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused	reviewbot	Nov. 18, 2020, 9:59 p.m.
F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused	reviewbot	Nov. 18, 2020, 9:59 p.m.
F401 'reviewboard.integrations.base.get_integration_manager' imported but unused	reviewbot	Nov. 18, 2020, 9:59 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2020, 9:59 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Nov. 18, 2020, 9:59 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 10 'authorize' is defined but never used.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 68 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 68 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 60 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 62 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 76 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 45 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 47 Expected '!==' and instead saw '!='.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 48 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 52 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 67 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 47 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 43 Expected '!==' and instead saw '!='.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 47 Expected '{' and instead saw 'return'.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 48 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 10 'gup' was used before it was defined.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 17 Missing semicolon.	reviewbot	Nov. 18, 2020, 9:59 p.m.
Col: 10 'authorize' is defined but never used.	reviewbot	Nov. 18, 2020, 10:16 p.m.
Col: 68 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 68 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 60 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 62 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 76 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 45 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 47 Expected '!==' and instead saw '!='.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 48 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 52 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 67 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 47 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 43 Expected '!==' and instead saw '!='.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 47 Expected '{' and instead saw 'return'.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 48 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 10 'gup' was used before it was defined.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 17 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:15 p.m.
Col: 10 'authorize' is defined but never used.	reviewbot	Nov. 18, 2020, 10:19 p.m.
Col: 47 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:19 p.m.
Col: 43 Expected '!==' and instead saw '!='.	reviewbot	Nov. 18, 2020, 10:19 p.m.
Col: 47 Expected '{' and instead saw 'return'.	reviewbot	Nov. 18, 2020, 10:19 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 18, 2020, 10:19 p.m.
Col: 48 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:19 p.m.
Col: 10 'gup' was used before it was defined.	reviewbot	Nov. 18, 2020, 10:19 p.m.
Col: 10 'authorize' is defined but never used.	reviewbot	Nov. 18, 2020, 10:22 p.m.
Col: 47 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:22 p.m.
Col: 43 Expected '!==' and instead saw '!='.	reviewbot	Nov. 18, 2020, 10:22 p.m.
Col: 47 Expected '{' and instead saw 'return'.	reviewbot	Nov. 18, 2020, 10:22 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 18, 2020, 10:22 p.m.
Col: 48 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:22 p.m.
Col: 10 'gup' was used before it was defined.	reviewbot	Nov. 18, 2020, 10:22 p.m.
Col: 10 'authorize' is defined but never used.	reviewbot	Nov. 18, 2020, 10:23 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 18, 2020, 10:23 p.m.
Col: 48 Missing semicolon.	reviewbot	Nov. 18, 2020, 10:23 p.m.
Col: 10 'authorize' is defined but never used.	reviewbot	Nov. 19, 2020, 12:34 a.m.

flake8 failed.

JSHint failed.

flake8

rbintegrations/slack/authorizeWidget.py (Diff revision 1)
Show all issues
```
F401 'django.conf.settings' imported but unused
```
rbintegrations/slack/authorizeWidget.py (Diff revision 1)
Show all issues
```
F401 'django.utils.html.format_html' imported but unused
```
rbintegrations/slack/authorizeWidget.py (Diff revision 1)
Show all issues
```
E501 line too long (147 > 79 characters)
```
rbintegrations/slack/authorizeWidget.py (Diff revision 1)
Show all issues
```
W292 no newline at end of file
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
E302 expected 2 blank lines, found 1
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```

rbintegrations/slack/forms.py (Diff revision 1)

Show all issues

E126 continuation line over-indented for hanging indent

rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
E265 block comment should start with '# '
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
E114 indentation is not a multiple of four (comment)
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
E116 unexpected indentation (comment)
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
E114 indentation is not a multiple of four (comment)
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
E116 unexpected indentation (comment)
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
E114 indentation is not a multiple of four (comment)
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
E116 unexpected indentation (comment)
```
rbintegrations/slack/forms.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```

rbintegrations/slack/views.py (Diff revision 1)

Show all issues

F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused

rbintegrations/slack/views.py (Diff revision 1)

Show all issues

F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused

rbintegrations/slack/views.py (Diff revision 1)

Show all issues

F401 'reviewboard.integrations.base.get_integration_manager' imported but unused

rbintegrations/slack/views.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```

rbintegrations/slack/views.py (Diff revision 1)

Show all issues

E251 unexpected spaces around keyword / parameter equals

rbintegrations/slack/views.py (Diff revision 1)

Show all issues

E251 unexpected spaces around keyword / parameter equals

JSHint

rbintegrations/static/js/slack/authorize.js (Diff revision 1)
Show all issues
```
Col: 10
 'authorize' is defined but never used.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 1)
Show all issues
```
Col: 68
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 1)
Show all issues
```
Col: 60
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 1)
Show all issues
```
Col: 62
 Missing semicolon.
```

Groups:

+	students

Commits:

	Summary	Author
-	[WIP] oauth slack	ruonan
-	[WIP] slack oauth	ruonan
+	[WIP] oauth slack	ruonan
+	[WIP] slack oauth	ruonan
+	[WIP] Slack oauth	ruonan
+	[WIP] Slack Integration	ruonan

Diff:

Revision 2 (+617 -103)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/authorizeWidget.py
	rbintegrations/slack/authorize_widget.html
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/urls.py
	rbintegrations/slack/views.py
	rbintegrations/static/js/slack/authorize.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

rbintegrations/slack/authorizeWidget.py (Diff revision 2)
Show all issues
```
F401 'django.conf.settings' imported but unused
```
rbintegrations/slack/authorizeWidget.py (Diff revision 2)
Show all issues
```
F401 'django.utils.html.format_html' imported but unused
```
rbintegrations/slack/authorizeWidget.py (Diff revision 2)
Show all issues
```
W292 no newline at end of file
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 1
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
E501 line too long (84 > 79 characters)
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
E303 too many blank lines (2)
```

rbintegrations/slack/forms.py (Diff revision 2)

Show all issues

E126 continuation line over-indented for hanging indent

rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/integration.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/integration.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/integration.py (Diff revision 2)
Show all issues
```
E303 too many blank lines (2)
```
rbintegrations/slack/integration.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ':'
```
rbintegrations/slack/views.py (Diff revision 2)
Show all issues
```
F401 'requests' imported but unused
```

rbintegrations/slack/views.py (Diff revision 2)

Show all issues

F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused

rbintegrations/slack/views.py (Diff revision 2)

Show all issues

F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused

rbintegrations/slack/views.py (Diff revision 2)

Show all issues

F401 'reviewboard.integrations.base.get_integration_manager' imported but unused

rbintegrations/slack/views.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/views.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/views.py (Diff revision 2)
Show all issues
```
E501 line too long (95 > 79 characters)
```

rbintegrations/slack/views.py (Diff revision 2)

Show all issues

E127 continuation line over-indented for visual indent

rbintegrations/slack/views.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/views.py (Diff revision 2)
Show all issues
```
W391 blank line at end of file
```

JSHint

rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 69
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 10
 'authorize' is defined but never used.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 68
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 60
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 62
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 76
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 45
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 47
 Expected '!==' and instead saw '!='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 48
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 52
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 67
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 47
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 43
 Expected '!==' and instead saw '!='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 47
 Expected '{' and instead saw 'return'.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 46
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 10
 'gup' was used before it was defined.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 2)
Show all issues
```
Col: 17
 Missing semicolon.
```

Commits:

	Summary	Author
-	[WIP] oauth slack	ruonan
-	[WIP] slack oauth	ruonan
-	[WIP] Slack oauth	ruonan
-	[WIP] Slack Integration	ruonan
+	[WIP] oauth slack	ruonan
+	[WIP] slack oauth	ruonan
+	[WIP] Slack oauth	ruonan
+	[WIP] Slack Integration	ruonan
+	Slack Oauth Integration	ruonan

Diff:

Revision 3 (+628 -112)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/authorizeWidget.py
	rbintegrations/slack/authorize_widget.html
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/urls.py
	rbintegrations/slack/views.py
	rbintegrations/static/js/slack/authorize.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 32 failures.
```
rbintegrations/slack/authorizeWidget.py (Diff revision 3)
Show all issues
```
F401 'django.conf.settings' imported but unused
```
rbintegrations/slack/authorizeWidget.py (Diff revision 3)
Show all issues
```
F401 'django.utils.html.format_html' imported but unused
```
rbintegrations/slack/authorizeWidget.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
rbintegrations/slack/authorizeWidget.py (Diff revision 3)
Show all issues
```
E501 line too long (95 > 79 characters)
```
rbintegrations/slack/authorizeWidget.py (Diff revision 3)
Show all issues
```
W292 no newline at end of file
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
E501 line too long (84 > 79 characters)
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
E303 too many blank lines (2)
```

rbintegrations/slack/forms.py (Diff revision 3)

Show all issues

E126 continuation line over-indented for hanging indent

rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/forms.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
rbintegrations/slack/integration.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/integration.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/integration.py (Diff revision 3)
Show all issues
```
E303 too many blank lines (2)
```
rbintegrations/slack/integration.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ':'
```
rbintegrations/slack/views.py (Diff revision 3)
Show all issues
```
F401 'requests' imported but unused
```

rbintegrations/slack/views.py (Diff revision 3)

Show all issues

F401 'django.utils.six.moves.urllib.parse.urlencode' imported but unused

rbintegrations/slack/views.py (Diff revision 3)

Show all issues

F401 'django.utils.six.moves.urllib.request.urlopen' imported but unused

rbintegrations/slack/views.py (Diff revision 3)

Show all issues

F401 'reviewboard.integrations.base.get_integration_manager' imported but unused

rbintegrations/slack/views.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/views.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/slack/views.py (Diff revision 3)
Show all issues
```
E501 line too long (95 > 79 characters)
```

rbintegrations/slack/views.py (Diff revision 3)

Show all issues

E127 continuation line over-indented for visual indent

JSHint

rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 10
 'authorize' is defined but never used.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 68
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 68
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 60
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 62
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 76
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 45
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 47
 Expected '!==' and instead saw '!='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 48
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 52
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 67
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 47
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 43
 Expected '!==' and instead saw '!='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 47
 Expected '{' and instead saw 'return'.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 48
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 10
 'gup' was used before it was defined.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 3)
Show all issues
```
Col: 17
 Missing semicolon.
```

Commits:

	Summary	Author
-	[WIP] oauth slack	ruonan
-	[WIP] slack oauth	ruonan
-	[WIP] Slack oauth	ruonan
-	[WIP] Slack Integration	ruonan
-	Slack Oauth Integration	ruonan
+	[WIP] oauth slack	ruonan
+	[WIP] slack oauth	ruonan
+	[WIP] Slack oauth	ruonan
+	[WIP] Slack Integration	ruonan
+	Slack Oauth Integration	ruonan
+	fix lint	ruonan

Diff:

Revision 4 (+645 -141)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/authorizeWidget.py
	rbintegrations/slack/authorize_widget.html
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/urls.py
	rbintegrations/slack/views.py
	rbintegrations/static/js/slack/authorize.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 10
 'authorize' is defined but never used.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 68
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 68
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 60
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 62
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 76
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 45
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 47
 Expected '!==' and instead saw '!='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 48
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 52
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 67
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 47
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 43
 Expected '!==' and instead saw '!='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 47
 Expected '{' and instead saw 'return'.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 48
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 10
 'gup' was used before it was defined.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 4)
Show all issues
```
Col: 17
 Missing semicolon.
```

Commits:

	Summary	Author
-	[WIP] oauth slack	ruonan
-	[WIP] slack oauth	ruonan
-	[WIP] Slack oauth	ruonan
-	[WIP] Slack Integration	ruonan
-	Slack Oauth Integration	ruonan
-	fix lint	ruonan
+	[WIP] oauth slack	ruonan
+	[WIP] slack oauth	ruonan
+	[WIP] Slack oauth	ruonan
+	[WIP] Slack Integration	ruonan
+	Slack Oauth Integration	ruonan
+	fix lint	ruonan
+	fix lint	ruonan

Diff:

Revision 5 (+654 -154)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/authorizeWidget.py
	rbintegrations/slack/authorize_widget.html
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/urls.py
	rbintegrations/slack/views.py
	rbintegrations/static/js/slack/authorize.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

rbintegrations/static/js/slack/authorize.js (Diff revision 5)
Show all issues
```
Col: 10
 'authorize' is defined but never used.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 5)
Show all issues
```
Col: 47
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 5)
Show all issues
```
Col: 43
 Expected '!==' and instead saw '!='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 5)
Show all issues
```
Col: 47
 Expected '{' and instead saw 'return'.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 5)
Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 5)
Show all issues
```
Col: 48
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 5)
Show all issues
```
Col: 10
 'gup' was used before it was defined.
```

Commits:

	Summary	Author
-	[WIP] oauth slack	ruonan
-	[WIP] slack oauth	ruonan
-	[WIP] Slack oauth	ruonan
-	[WIP] Slack Integration	ruonan
-	Slack Oauth Integration	ruonan
-	fix lint	ruonan
-	fix lint	ruonan
+	[WIP] oauth slack	ruonan
+	[WIP] slack oauth	ruonan
+	[WIP] Slack oauth	ruonan
+	[WIP] Slack Integration	ruonan
+	Slack Oauth Integration	ruonan
+	fix lint	ruonan
+	fix lint	ruonan

Diff:

Revision 6 (+654 -154)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/authorizeWidget.py
	rbintegrations/slack/authorize_widget.html
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/urls.py
	rbintegrations/slack/views.py
	rbintegrations/static/js/slack/authorize.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

rbintegrations/static/js/slack/authorize.js (Diff revision 6)
Show all issues
```
Col: 10
 'authorize' is defined but never used.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 6)
Show all issues
```
Col: 47
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 6)
Show all issues
```
Col: 43
 Expected '!==' and instead saw '!='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 6)
Show all issues
```
Col: 47
 Expected '{' and instead saw 'return'.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 6)
Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 6)
Show all issues
```
Col: 48
 Missing semicolon.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 6)
Show all issues
```
Col: 10
 'gup' was used before it was defined.
```

Commits:

	Summary	Author
-	[WIP] oauth slack	ruonan
-	[WIP] slack oauth	ruonan
-	[WIP] Slack oauth	ruonan
-	[WIP] Slack Integration	ruonan
-	Slack Oauth Integration	ruonan
-	fix lint	ruonan
-	fix lint	ruonan
+	[WIP] oauth slack	ruonan
+	[WIP] slack oauth	ruonan
+	[WIP] Slack oauth	ruonan
+	[WIP] Slack Integration	ruonan
+	Slack Oauth Integration	ruonan
+	fix lint	ruonan
+	fix lint	ruonan
+	fix lint	ruonan

Diff:

Revision 7 (+666 -162)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/authorizeWidget.py
	rbintegrations/slack/authorize_widget.html
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/urls.py
	rbintegrations/slack/views.py
	rbintegrations/static/js/slack/authorize.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

rbintegrations/static/js/slack/authorize.js (Diff revision 7)
Show all issues
```
Col: 10
 'authorize' is defined but never used.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 7)
Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
rbintegrations/static/js/slack/authorize.js (Diff revision 7)
Show all issues
```
Col: 48
 Missing semicolon.
```

Commits:

	Summary	Author
-	[WIP] oauth slack	ruonan
-	[WIP] slack oauth	ruonan
-	[WIP] Slack oauth	ruonan
-	[WIP] Slack Integration	ruonan
-	Slack Oauth Integration	ruonan
-	fix lint	ruonan
-	fix lint	ruonan
-	fix lint	ruonan
+	[WIP] oauth slack	ruonan
+	[WIP] slack oauth	ruonan
+	[WIP] Slack oauth	ruonan
+	[WIP] Slack Integration	ruonan
+	Slack Oauth Integration	ruonan
+	fix lint	ruonan
+	fix lint	ruonan
+	fix lint	ruonan
+	fix lint	ruonan

Diff:

Revision 8 (+668 -164)

Show changes

	rbintegrations/extension.py
	rbintegrations/slack/authorizeWidget.py
	rbintegrations/slack/authorize_widget.html
	rbintegrations/slack/forms.py
	rbintegrations/slack/integration.py
	rbintegrations/slack/urls.py
	rbintegrations/slack/views.py
	rbintegrations/static/js/slack/authorize.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

rbintegrations/static/js/slack/authorize.js (Diff revision 8)
Show all issues
```
Col: 10
 'authorize' is defined but never used.
```

You have a pending review.

Review Board 5.0.2 alpha 0 (dev)

[WIP] oauth slack

flake8

JSHint

Groups:

Commits:

Diff:

Checks run (2 failed)

flake8

JSHint

Commits:

Diff:

Checks run (2 failed)

flake8

JSHint

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

JSHint

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

JSHint

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

JSHint

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

JSHint

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

JSHint

Status: Discarded