Summary

[WIP] Add unit tests for djblets.log.views

Review Request #11234 — Created Oct. 19, 2020 and discarded Dec. 3, 2020, 3:31 p.m.

Information

Owner

Tatenda

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

added more test for the iter_log_lines

Testing Done

manual testing all tests passed

Commits

Summary	ID	Author
added more tests for iter_log_lines function and rebased branch to get rid of excess files	f55fa3695f8d8aa7434ef7929e73ef8ae7409538	TATENDA CHIVASA

Issues

Description	From	Last Updated
Please make sure your summary and description match our standards: https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea	david	Oct. 23, 2020, 1:17 p.m.
It looks like a whole bunch of temporary and ephemeral files got added to this change. Can you reset (using …	david	Oct. 30, 2020, noon
In your summary, there's a typo (djiblets -> djblets). This should probably also be marked as WIP for now, since …	david	Oct. 30, 2020, 12:05 p.m.
W291 trailing whitespace	reviewbot	Oct. 30, 2020, 11:59 a.m.
F401 'sys' imported but unused	reviewbot	Oct. 30, 2020, 11:59 a.m.
W291 trailing whitespace	reviewbot	Oct. 30, 2020, 11:59 a.m.
F403 'from djblets.log.views import *' used; unable to detect undefined names	reviewbot	Oct. 30, 2020, 11:59 a.m.
W291 trailing whitespace	reviewbot	Oct. 30, 2020, 11:59 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 30, 2020, 11:59 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2020, 11:59 a.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 11:59 a.m.
E501 line too long (81 > 79 characters)	reviewbot	Oct. 30, 2020, 11:59 a.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 11:59 a.m.
E501 line too long (99 > 79 characters)	reviewbot	Oct. 30, 2020, 11:59 a.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 11:59 a.m.
E501 line too long (93 > 79 characters)	reviewbot	Oct. 30, 2020, 11:59 a.m.
F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 11:59 a.m.
E231 missing whitespace after ','	reviewbot	Oct. 30, 2020, 11:59 a.m.
W293 blank line contains whitespace	reviewbot	Oct. 30, 2020, 11:59 a.m.
W291 trailing whitespace	reviewbot	Oct. 30, 2020, 11:59 a.m.
F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 11:59 a.m.
E501 line too long (101 > 79 characters)	reviewbot	Oct. 30, 2020, 11:59 a.m.
E202 whitespace before ')'	reviewbot	Oct. 30, 2020, 11:59 a.m.
F841 local variable 'one_week_ago' is assigned to but never used	reviewbot	Oct. 30, 2020, 11:59 a.m.
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, noon
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, noon
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, noon
E127 continuation line over-indented for visual indent	reviewbot	Oct. 30, 2020, noon
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, noon
E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 30, 2020, noon
E203 whitespace before ','	reviewbot	Oct. 30, 2020, noon
E501 line too long (96 > 79 characters)	reviewbot	Oct. 30, 2020, noon
W293 blank line contains whitespace	reviewbot	Oct. 30, 2020, noon
These files are showing up as changed because you've pulled on master but haven't rebased your branch. You'll want to …	david	Oct. 30, 2020, 12:06 p.m.
F401 'sys' imported but unused	reviewbot	Oct. 30, 2020, noon
W291 trailing whitespace	reviewbot	Oct. 30, 2020, noon
F403 'from djblets.log.views import *' used; unable to detect undefined names	reviewbot	Oct. 30, 2020, noon
W291 trailing whitespace	reviewbot	Oct. 30, 2020, noon
E302 expected 2 blank lines, found 1	reviewbot	Oct. 30, 2020, 12:01 p.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2020, 12:01 p.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 12:01 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Oct. 30, 2020, 12:01 p.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 12:01 p.m.
E501 line too long (99 > 79 characters)	reviewbot	Oct. 30, 2020, 12:01 p.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 12:01 p.m.
E501 line too long (93 > 79 characters)	reviewbot	Oct. 30, 2020, 12:01 p.m.
F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 12:01 p.m.
E231 missing whitespace after ','	reviewbot	Oct. 30, 2020, 12:01 p.m.
W293 blank line contains whitespace	reviewbot	Oct. 30, 2020, 12:01 p.m.
W291 trailing whitespace	reviewbot	Oct. 30, 2020, 12:01 p.m.
F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 12:01 p.m.
E501 line too long (101 > 79 characters)	reviewbot	Oct. 30, 2020, 12:01 p.m.
E202 whitespace before ')'	reviewbot	Oct. 30, 2020, 12:01 p.m.
F841 local variable 'one_week_ago' is assigned to but never used	reviewbot	Oct. 30, 2020, 12:01 p.m.
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 12:01 p.m.
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, noon
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, noon
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, noon
E127 continuation line over-indented for visual indent	reviewbot	Oct. 30, 2020, 12:01 p.m.
E501 line too long (96 > 79 characters)	reviewbot	Oct. 30, 2020, noon
E203 whitespace before ','	reviewbot	Oct. 30, 2020, noon
E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 30, 2020, noon
W293 blank line contains whitespace	reviewbot	Oct. 30, 2020, noon
E303 too many blank lines (3)	reviewbot	Oct. 30, 2020, noon
F401 'sys' imported but unused	reviewbot	Oct. 30, 2020, 10:57 a.m.
W291 trailing whitespace	reviewbot	Oct. 30, 2020, 10:57 a.m.
F403 'from djblets.log.views import *' used; unable to detect undefined names	reviewbot	Oct. 30, 2020, 10:57 a.m.
W291 trailing whitespace	reviewbot	Oct. 30, 2020, 10:57 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 30, 2020, 10:57 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2020, 10:57 a.m.
E501 line too long (81 > 79 characters)	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2020, 10:57 a.m.
E501 line too long (99 > 79 characters)	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
E501 line too long (93 > 79 characters)	reviewbot	Oct. 30, 2020, 10:57 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
E231 missing whitespace after ','	reviewbot	Oct. 30, 2020, 10:57 a.m.
W293 blank line contains whitespace	reviewbot	Oct. 30, 2020, 10:57 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2020, 10:57 a.m.
W291 trailing whitespace	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
E501 line too long (101 > 79 characters)	reviewbot	Oct. 30, 2020, 10:57 a.m.
E202 whitespace before ')'	reviewbot	Oct. 30, 2020, 10:57 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
E127 continuation line over-indented for visual indent	reviewbot	Oct. 30, 2020, 10:57 a.m.
F405 'settings' may be undefined, or defined from star imports: djblets.log.views	reviewbot	Oct. 30, 2020, 10:57 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 30, 2020, 10:57 a.m.

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 66 failures.
```
djblets/extensions/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'sys' imported but unused
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F403 'from djblets.log.views import *' used; unable to detect undefined names
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```

djblets/log/tests/test_views.py (Diff revision 1)

The issue has been resolved. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```

djblets/log/tests/test_views.py (Diff revision 1)

The issue has been resolved. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (99 > 79 characters)
```

djblets/log/tests/test_views.py (Diff revision 1)

The issue has been resolved. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (93 > 79 characters)
```

djblets/log/tests/test_views.py (Diff revision 1)

The issue has been resolved. Show all issues

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

djblets/log/tests/test_views.py (Diff revision 1)

The issue has been resolved. Show all issues

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (101 > 79 characters)
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'one_week_ago' is assigned to but never used
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F405 'settings' may be undefined, or defined from star imports: djblets.log.views
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F405 'settings' may be undefined, or defined from star imports: djblets.log.views
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F405 'settings' may be undefined, or defined from star imports: djblets.log.views
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F405 'settings' may be undefined, or defined from star imports: djblets.log.views
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (96 > 79 characters)
```
djblets/log/tests/test_views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

The issue has been resolved. Show all issues

It looks like a whole bunch of temporary and ephemeral files got added to this change. Can you reset (using --mixed) back to master and then only add the files that you intended to?

I was getting a bunch of formatting errors at once too on my commits. I found running the following command helpful before I committed new changes :)

flake8 --ignore E121,E125,E129,E241 --max-line-length 79

Commits:

Summary	ID	Author
add unit tests for djiblets.log.views	e190529dc708aedfb6426f6be888f8053a434427	TATENDA CHIVASA
tests for djblest log views	5b9396bca2a5d986628fea4d1bbb1f6cc65c3a36	TATENDA CHIVASA
tests for djblets log views	cc288127565dc78220ce728704bc6c654a4c7dca	TATENDA CHIVASA
added tests for log view for all except iter log lines	c89682e3e4f2d598e1cae0bd23de5ba7f44055ee	TATENDA CHIVASA
added tests for log view	21945d6415087bce4c217d20763761656b9934ee	TATENDA CHIVASA
removed extra files in commit for djblest log view unit tests	d4ec889b4efaab815924d5a880df30fd7aaf29b2	TATENDA CHIVASA

Diff:

Revision 2 (+341 -15)

Show changes

	djblets/dependencies.py
	djblets/settings.py
	djblets/log/tests/test_views.py
	djblets/static/djblets/css/datagrid.less
	tests/settings.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 64 failures.
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F401 'sys' imported but unused
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F403 'from djblets.log.views import *' used; unable to detect undefined names
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```

djblets/log/tests/test_views.py (Diff revision 2)

The issue has been resolved. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```

djblets/log/tests/test_views.py (Diff revision 2)

The issue has been resolved. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (99 > 79 characters)
```

djblets/log/tests/test_views.py (Diff revision 2)

The issue has been resolved. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (93 > 79 characters)
```

djblets/log/tests/test_views.py (Diff revision 2)

The issue has been resolved. Show all issues

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

djblets/log/tests/test_views.py (Diff revision 2)

The issue has been resolved. Show all issues

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (101 > 79 characters)
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F841 local variable 'one_week_ago' is assigned to but never used
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F405 'settings' may be undefined, or defined from star imports: djblets.log.views
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F405 'settings' may be undefined, or defined from star imports: djblets.log.views
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F405 'settings' may be undefined, or defined from star imports: djblets.log.views
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F405 'settings' may be undefined, or defined from star imports: djblets.log.views
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (96 > 79 characters)
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E303 too many blank lines (3)
```

Fix it!

An issue was opened. Show all issues

Please make sure your summary and description match our standards: https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea

The issue has been resolved. Show all issues

In your summary, there's a typo (djiblets -> djblets). This should probably also be marked as WIP for now, since it seems like there's still a fair bit of work to do.

djblets/dependencies.py (Diff revision 2)

The issue has been resolved. Show all issues

These files are showing up as changed because you've pulled on master but haven't rebased your branch. You'll want to rebase your branch on top of the latest master (git rebase master branchname) and then post again.

Summary:

-	add unit tests for djiblets.log.views
+	[WIP] add unit tests for djblets.log.views

Commits:

	Summary	ID	Author
	removed extra files in commit for djblest log view unit tests	d4ec889b4efaab815924d5a880df30fd7aaf29b2	TATENDA CHIVASA
	added more tests for iter_log_lines function and rebased branch to get rid of excess files	f55fa3695f8d8aa7434ef7929e73ef8ae7409538	TATENDA CHIVASA

Diff:

Revision 3 (+428)

Show changes

djblets/log/tests/test_views.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 94 failures.
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
F401 'sys' imported but unused
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
W291 trailing whitespace
```

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F403 'from djblets.log.views import *' used; unable to detect undefined names

djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E501 line too long (81 > 79 characters)
```

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E501 line too long (99 > 79 characters)
```

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E501 line too long (93 > 79 characters)
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
W291 trailing whitespace
```

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E501 line too long (101 > 79 characters)
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E127 continuation line over-indented for visual indent
```

djblets/log/tests/test_views.py (Diff revision 3)

An issue was opened. Show all issues

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

djblets/log/tests/test_views.py (Diff revision 3)
An issue was opened. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```

Summary:

-	[WIP] add unit tests for djblets.log.views
+	[WIP] Add unit tests for djblets.log.views

Description:

~		added tests for log view for all except iter log lines
	~	added more test for the iter_log_lines

Review Board 7.0 alpha 0 (dev)

[WIP] Add unit tests for djblets.log.views

Information

Reviewers

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Summary:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Summary:

Description:

Status: Discarded