[WIP] Add unit tests for djblets.log.views

Review Request #11234 — Created Oct. 19, 2020 and discarded

Information

Djblets
master

Reviewers

added more test for the iter_log_lines

manual testing all tests passed

Summary ID Author
added more tests for iter_log_lines function and rebased branch to get rid of excess files
f55fa3695f8d8aa7434ef7929e73ef8ae7409538 TATENDA CHIVASA
Description From Last Updated

Please make sure your summary and description match our standards: https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea

daviddavid

It looks like a whole bunch of temporary and ephemeral files got added to this change. Can you reset (using …

daviddavid

In your summary, there's a typo (djiblets -> djblets). This should probably also be marked as WIP for now, since …

daviddavid

W291 trailing whitespace

reviewbotreviewbot

F401 'sys' imported but unused

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F403 'from djblets.log.views import *' used; unable to detect undefined names

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (81 > 79 characters)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (99 > 79 characters)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (93 > 79 characters)

reviewbotreviewbot

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (101 > 79 characters)

reviewbotreviewbot

E202 whitespace before ')'

reviewbotreviewbot

F841 local variable 'one_week_ago' is assigned to but never used

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E203 whitespace before ','

reviewbotreviewbot

E501 line too long (96 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

These files are showing up as changed because you've pulled on master but haven't rebased your branch. You'll want to …

daviddavid

F401 'sys' imported but unused

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F403 'from djblets.log.views import *' used; unable to detect undefined names

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (81 > 79 characters)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (99 > 79 characters)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (93 > 79 characters)

reviewbotreviewbot

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (101 > 79 characters)

reviewbotreviewbot

E202 whitespace before ')'

reviewbotreviewbot

F841 local variable 'one_week_ago' is assigned to but never used

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E501 line too long (96 > 79 characters)

reviewbotreviewbot

E203 whitespace before ','

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E303 too many blank lines (3)

reviewbotreviewbot

F401 'sys' imported but unused

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F403 'from djblets.log.views import *' used; unable to detect undefined names

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E501 line too long (81 > 79 characters)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E501 line too long (99 > 79 characters)

reviewbotreviewbot

F405 'parse_timestamp' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (93 > 79 characters)

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F405 'build_query_string' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E501 line too long (101 > 79 characters)

reviewbotreviewbot

E202 whitespace before ')'

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

F405 'settings' may be undefined, or defined from star imports: djblets.log.views

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. It looks like a whole bunch of temporary and ephemeral files got added to this change. Can you reset (using --mixed) back to master and then only add the files that you intended to?

  3. 
      
ruonanjia
  1. I was getting a bunch of formatting errors at once too on my commits. I found running the following command helpful before I committed new changes :)

    flake8 --ignore E121,E125,E129,E241 --max-line-length 79

  2. 
      
Tatenda
Review request changed

Commits:

Summary ID Author
add unit tests for djiblets.log.views
e190529dc708aedfb6426f6be888f8053a434427 TATENDA CHIVASA
tests for djblest log views
5b9396bca2a5d986628fea4d1bbb1f6cc65c3a36 TATENDA CHIVASA
tests for djblets log views
cc288127565dc78220ce728704bc6c654a4c7dca TATENDA CHIVASA
added tests for log view for all except iter log lines
c89682e3e4f2d598e1cae0bd23de5ba7f44055ee TATENDA CHIVASA
added tests for log view
21945d6415087bce4c217d20763761656b9934ee TATENDA CHIVASA
removed extra files in commit for djblest log view unit tests
d4ec889b4efaab815924d5a880df30fd7aaf29b2 TATENDA CHIVASA

Diff:

Revision 2 (+341 -15)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. Please make sure your summary and description match our standards: https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea

  3. In your summary, there's a typo (djiblets -> djblets). This should probably also be marked as WIP for now, since it seems like there's still a fair bit of work to do.

  4. djblets/dependencies.py (Diff revision 2)
     
     
     
     
     
     

    These files are showing up as changed because you've pulled on master but haven't rebased your branch. You'll want to rebase your branch on top of the latest master (git rebase master branchname) and then post again.

  5. 
      
Tatenda
Review request changed

Summary:

-add unit tests for djiblets.log.views
+[WIP] add unit tests for djblets.log.views

Commits:

Summary ID Author
removed extra files in commit for djblest log view unit tests
d4ec889b4efaab815924d5a880df30fd7aaf29b2 TATENDA CHIVASA
added more tests for iter_log_lines function and rebased branch to get rid of excess files
f55fa3695f8d8aa7434ef7929e73ef8ae7409538 TATENDA CHIVASA

Diff:

Revision 3 (+428)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. 
      
Tatenda
david
Review request changed

Status: Discarded

Loading...