Summary

Microsoft Teams Integration Option

Review Request #11227 — Created Oct. 16, 2020 and updated Dec. 18, 2020, 2:57 p.m.

Information

Owner

hailan

Repository

rbintegrations

Branch

master

Bugs

Depends On

Reviewers

Groups

rbintegrations, students

People

Description

Added the Microsoft Teams Integration Option. Like the existing Slack
Integration option, this integration will post a message to an MS Teams chat
channel after a review request has been updated.

MS Teams icons are acquired from Adaptive Cards' main webpage:
https://adaptivecards.io/

Testing Done

Unit tests passed and manually tested it in RB3.0 and 4.0.

Commits

Summary	ID	Author
Microsoft Teams Integration Option	fd6fe6409a66b76ca6d933ae842651a12fcbe6d8	HailanXyouknow

Files

Issues

Description	From	Last Updated
How about renaming the module from microsoftteams to msteams? It'll be shorter and imports won't have to wrap.	chipx86	Dec. 18, 2020, 12:26 p.m.
E501 line too long (172 > 79 characters)	reviewbot	Nov. 3, 2020, 9:41 p.m.
E501 line too long (210 > 79 characters)	reviewbot	Nov. 3, 2020, 9:41 p.m.
E262 inline comment should start with '# '	reviewbot	Nov. 3, 2020, 9:41 p.m.
W292 no newline at end of file	reviewbot	Nov. 3, 2020, 9:41 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
E266 too many leading '#' for block comment	reviewbot	Nov. 3, 2020, 9:42 p.m.
E231 missing whitespace after ':'	reviewbot	Nov. 3, 2020, 9:42 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
E303 too many blank lines (3)	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Nov. 3, 2020, 9:42 p.m.
E231 missing whitespace after ':'	reviewbot	Nov. 3, 2020, 9:42 p.m.
E262 inline comment should start with '# '	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 3, 2020, 9:42 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 3, 2020, 9:42 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 3, 2020, 9:42 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 3, 2020, 9:42 p.m.
E501 line too long (210 > 79 characters)	reviewbot	Nov. 3, 2020, 9:42 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 3, 2020, 9:42 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Nov. 3, 2020, 9:42 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Nov. 3, 2020, 9:42 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Nov. 3, 2020, 9:42 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Nov. 3, 2020, 9:42 p.m.
E501 line too long (115 > 79 characters)	reviewbot	Nov. 3, 2020, 9:42 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Nov. 3, 2020, 9:42 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Nov. 3, 2020, 9:42 p.m.
E262 inline comment should start with '# '	reviewbot	Nov. 3, 2020, 9:42 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 5, 2020, 4:08 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Nov. 5, 2020, 4:45 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 5, 2020, 4:45 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Nov. 5, 2020, 8:16 p.m.
Should swap lines 10 and 13, so that they are in alphabetical order.	jblazusi	Nov. 21, 2020, 5:41 p.m.
logger = logging.getLogger(__name__) should have 2 lines before and 2 lines after.	jblazusi	Nov. 21, 2020, 5:41 p.m.
This could also be if, elif, else. Not sure what the mentors prefer.	jblazusi	Nov. 21, 2020, 5:41 p.m.
not a must change but could also use a switch-case statement	ruonanjia	Nov. 21, 2020, 5:41 p.m.
Comment should have a period.	jblazusi	Nov. 21, 2020, 6:06 p.m.
Comment should have a period.	jblazusi	Nov. 21, 2020, 6:06 p.m.
I think it is good practice to include the alt attribute for img tags in html.	jblazusi	Nov. 21, 2020, 5:53 p.m.
Looks like a debug statement, we should remove these.	jblazusi	Nov. 21, 2020, 6:06 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 21, 2020, 6:10 p.m.
Please add a module docstring.	david	Dec. 3, 2020, 2:43 p.m.
This isn't actually used (the call site is using the top-level function). However, I think what I'd do is move …	david	Dec. 3, 2020, 2:45 p.m.
What's left to do here?	david	Dec. 3, 2020, 2:46 p.m.
When we wrap the docstring, we put the final """ on its own line. I think I marked all the …	david	Dec. 3, 2020, 2:48 p.m.
What's left to do here?	david	Dec. 3, 2020, 2:46 p.m.
When we wrap the docstring, we put the final """ on its own line.	david	Dec. 3, 2020, 3:21 p.m.
When we wrap the docstring, we put the final """ on its own line.	david	Dec. 3, 2020, 3:21 p.m.
When we wrap the docstring, we put the final """ on its own line.	david	Dec. 3, 2020, 3:21 p.m.
When we wrap the docstring, we put the final """ on its own line.	david	Dec. 3, 2020, 3:21 p.m.
There's an extra "!" here.	david	Dec. 3, 2020, 3:21 p.m.
When we wrap the docstring, we put the final """ on its own line.	david	Dec. 3, 2020, 3:21 p.m.
When we wrap the docstring, we put the final """ on its own line.	david	Dec. 3, 2020, 3:21 p.m.
When we wrap the docstring, we put the final """ on its own line.	david	Dec. 3, 2020, 3:21 p.m.
This should end in a period (since it's not a test case docstring). Please also add "Args" and "Returns" sections.	david	Dec. 3, 2020, 3:21 p.m.
Blank line after this. We ahould also just have a variable for the emoji name and code, rather than a …	chipx86	Dec. 18, 2020, 2:51 p.m.
Blank line between these.	chipx86	Dec. 18, 2020, 2:31 p.m.
No need for the parens around the ... is ....	chipx86	Dec. 18, 2020, 2:29 p.m.
We should use format_html(), since it's safer (the arguments going in will be HTML-escaped).	chipx86	Dec. 18, 2020, 2:28 p.m.
This should use .copy() instead of dict(...).	chipx86	Dec. 18, 2020, 2:02 p.m.
We standardize on lowercase utf-8.	chipx86	Dec. 18, 2020, 2 p.m.
Docstring summaries must be one line without wrapping.	chipx86	Dec. 18, 2020, 2 p.m.

flake8 failed.

JSHint passed.

flake8

rbintegrations/microsoftteams/test.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (172 > 79 characters)
```
rbintegrations/microsoftteams/test.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (210 > 79 characters)
```
rbintegrations/microsoftteams/test.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E262 inline comment should start with '# '
```
rbintegrations/microsoftteams/test.py (Diff revision 1)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```

Change Summary:

Started to implement changes in integration.py

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	63b98a256884f896119f9d618224cd8ef25dd2c0	HailanXyouknow
	Microsoft Teams Integration Option	5bdd71e79b0b216d6a0fca4e18dc4a3a7d622faf	HailanXyouknow

Diff:

Revision 2 (+686)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/test.py
	rbintegrations/slack/integration.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbintegrations/microsoftteams/integration.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/integration.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/integration.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E266 too many leading '#' for block comment
```
rbintegrations/microsoftteams/integration.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ':'
```
rbintegrations/microsoftteams/test.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```
rbintegrations/microsoftteams/test.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/test.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/test.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E303 too many blank lines (3)
```
rbintegrations/microsoftteams/test.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/test.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
rbintegrations/microsoftteams/test.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ':'
```
rbintegrations/microsoftteams/test.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E262 inline comment should start with '# '
```

Change Summary:

Finished adding all fields to payload.
Manually tested it: looks fine on desktop version of MS Teams.
On the mobile app it doesn't show the attached image_url or thumb_url.

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	5bdd71e79b0b216d6a0fca4e18dc4a3a7d622faf	HailanXyouknow
	Microsoft Teams Integration Option	284e4f830502d90dfa78854ff579287cb63c0346	HailanXyouknow

Diff:

Revision 3 (+1588)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/integration0.py
	rbintegrations/microsoftteams/test.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E303 too many blank lines (2)
```
rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```
rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
rbintegrations/microsoftteams/integration0.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (210 > 79 characters)
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E122 continuation line missing indentation or outdented
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E122 continuation line missing indentation or outdented
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E122 continuation line missing indentation or outdented
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E122 continuation line missing indentation or outdented
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (115 > 79 characters)
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (91 > 79 characters)
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E122 continuation line missing indentation or outdented
```
rbintegrations/microsoftteams/test.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E262 inline comment should start with '# '
```

Added Files:

Description:

~		Currently investigating different fields available in the MS Teams API.
~		Will match up the arugments available through RB in next update
	~	Added the Microsoft Teams Integration Option.
	~	Will be adding tests.py in the next update.

Change Summary:

Clean up integrations.py

Description:

		Added the Microsoft Teams Integration Option.
~		Will be adding tests.py in the next update.
	~	MS Teams icons are acquired from Adaptive Cards' main webpage:
	+	https://adaptivecards.io/

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	284e4f830502d90dfa78854ff579287cb63c0346	HailanXyouknow
	Microsoft Teams Integration Option	05ab88185485763b58aa3f6fc63a8accc7816ebb	HailanXyouknow

Diff:

Revision 4 (+462)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Removed Files:

Added Files:

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbintegrations/microsoftteams/integration.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```

Change Summary:

Unit tests in tests.py

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	05ab88185485763b58aa3f6fc63a8accc7816ebb	HailanXyouknow
	Microsoft Teams Integration Option	804baf13e274da399d79ae09f8b3e79c13a8f9d7	HailanXyouknow

Diff:

Revision 5 (+3430)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbintegrations/microsoftteams/tests.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E501 line too long (86 > 79 characters)
```
1. hailan Nov. 5, 2020, 6:31 p.m.
  hello
rbintegrations/microsoftteams/tests.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```

Change Summary:

Update tests.py

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	804baf13e274da399d79ae09f8b3e79c13a8f9d7	HailanXyouknow
	Microsoft Teams Integration Option	b3952112d0fd5c806cc84a688da237e9089ffc85	HailanXyouknow

Diff:

Revision 6 (+3528)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/forms.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbintegrations/microsoftteams/integration.py (Diff revision 6)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	b3952112d0fd5c806cc84a688da237e9089ffc85	HailanXyouknow
	Microsoft Teams Integration Option	8ca4af09382a6baa1af145ef49aa7d7bc82fbcf5	HailanXyouknow

Diff:

Revision 7 (+3532)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/forms.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	[WIP] Microsoft Teams Integration Option
+	Microsoft Teams Integration Option

Testing Done:

Unit tests passed and manually tested it in RB3.0 and 4.0.

rbintegrations/microsoftteams/integration.py (Diff revision 7)
The issue has been resolved. Show all issues
```
not a must change but could also use a switch-case statement
```

I manually tested the integration, it works great!
I also ran the automated tests and I had similar issues that the Discord Integration had, which was the 2 test failures.
Otherwise, everything looks good to me, except for some styling. I did my best to review, although, I am not an expert on the integrations side of Review Board.

rbintegrations/microsoftteams/integration.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Should swap lines 10 and 13, so that they are in alphabetical order.
```
rbintegrations/microsoftteams/integration.py (Diff revision 7)
The issue has been resolved. Show all issues
```
logger = logging.getLogger(__name__) should have 2 lines before and 2 lines after.
```
rbintegrations/microsoftteams/integration.py (Diff revision 7)
The issue has been resolved. Show all issues
```
This could also be if, elif, else. Not sure what the mentors prefer.
```
rbintegrations/microsoftteams/integration.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Comment should have a period.
```
rbintegrations/microsoftteams/integration.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Comment should have a period.
```
rbintegrations/microsoftteams/integration.py (Diff revision 7)
The issue has been resolved. Show all issues
```
I think it is good practice to include the alt attribute for img tags in html.
```
rbintegrations/microsoftteams/integration.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Looks like a debug statement, we should remove these.
```

Change Summary:

Address Ruonan and Jacob's feedbacks

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	8ca4af09382a6baa1af145ef49aa7d7bc82fbcf5	HailanXyouknow
	Microsoft Teams Integration Option	bc2825462f681893720180b059ac596376661f75	HailanXyouknow

Diff:

Revision 8 (+3526)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/forms.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbintegrations/microsoftteams/integration.py (Diff revision 8)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Change Summary:

Address white space

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	bc2825462f681893720180b059ac596376661f75	HailanXyouknow
	Microsoft Teams Integration Option	b5cad1541c82eaa81a6b3f160561ec282e7740fd	HailanXyouknow

Diff:

Revision 9 (+3526)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/forms.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Updated forms.py - the old help text is difficult to read

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	b5cad1541c82eaa81a6b3f160561ec282e7740fd	HailanXyouknow
	Microsoft Teams Integration Option	2a888e3b7ef80588b2bceee92835ab26e669faff	HailanXyouknow

Diff:

Revision 10 (+3524)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/forms.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Capitalize the word Webhook

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	2a888e3b7ef80588b2bceee92835ab26e669faff	HailanXyouknow
	Microsoft Teams Integration Option	244565bcc337171c5ccbfdd657551e3f12a6dbff	HailanXyouknow

Diff:

Revision 11 (+3524)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/forms.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbintegrations/microsoftteams/integration.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Please add a module docstring.
```

rbintegrations/microsoftteams/integration.py (Diff revision 11)

The issue has been resolved. Show all issues

This isn't actually used (the call site is using the top-level function). However, I think what I'd do is move the contents of that function into this one, and then change the call site to use self.format_link.

rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
What's left to do here?
```

rbintegrations/microsoftteams/tests.py (Diff revision 11)

The issue has been resolved. Show all issues

When we wrap the docstring, we put the final """ on its own line. I think I marked all the places where this happens but please go through and check all the test cases.

rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
What's left to do here?
```
rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
When we wrap the docstring, we put the final """ on its own line.
```
rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
When we wrap the docstring, we put the final """ on its own line.
```
rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
When we wrap the docstring, we put the final """ on its own line.
```
rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
When we wrap the docstring, we put the final """ on its own line.
```
rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
There's an extra "!" here.
```
rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
When we wrap the docstring, we put the final """ on its own line.
```
rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
When we wrap the docstring, we put the final """ on its own line.
```
rbintegrations/microsoftteams/tests.py (Diff revision 11)
The issue has been resolved. Show all issues
```
When we wrap the docstring, we put the final """ on its own line.
```

rbintegrations/microsoftteams/tests.py (Diff revision 11)

The issue has been resolved. Show all issues

This should end in a period (since it's not a test case docstring). Please also add "Args" and "Returns" sections.

Change Summary:

Addressed David's feedback.

Description:

~		Added the Microsoft Teams Integration Option.
~		MS Teams icons are acquired from Adaptive Cards' main webpage:
	~	Added the Microsoft Teams Integration Option. Like the existing Slack
	~	Integration option, this integration will post a message to an MS Teams chat
	+	channel after a review request has been updated.
	+
	+	MS Teams icons are acquired from Adaptive Cards' main webpage:
		https://adaptivecards.io/

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	244565bcc337171c5ccbfdd657551e3f12a6dbff	HailanXyouknow
	Microsoft Teams Integration Option	0d437127a0b3edf449831a39e05d8604342a6958	HailanXyouknow

Diff:

Revision 12 (+3504)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/forms.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added `.encode('UTF-8')` to our request.

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	0d437127a0b3edf449831a39e05d8604342a6958	HailanXyouknow
	Microsoft Teams Integration Option	5b8cfb6111e99ac52f5570e53d83849cbadd1ed3	HailanXyouknow

Diff:

Revision 13 (+3504)

Show changes

	rbintegrations/extension.py
	rbintegrations/microsoftteams/__init__.py
	rbintegrations/microsoftteams/forms.py
	rbintegrations/microsoftteams/integration.py
	rbintegrations/microsoftteams/tests.py
	rbintegrations/static/images/microsoftteams/icon.png
	rbintegrations/static/images/microsoftteams/icon@2x.png

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

This is great! Thanks for working on this :)

The semester is over, and you're probably ready for a break. We're ready to release very soon, so it's completely up to you whether you want to take on the review feedback here or leave it up to us.

The issue has been resolved. Show all issues

How about renaming the module from microsoftteams to msteams? It'll be shorter and imports won't have to wrap.

rbintegrations/microsoftteams/integration.py (Diff revision 13)

The issue has been resolved. Show all issues

Blank line after this.

We ahould also just have a variable for the emoji name and code, rather than a dictionary, since they're local. It'll be faster to access a local variable than a dictionary key, and it'll look cleaner.

rbintegrations/microsoftteams/integration.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Blank line between these.
```
rbintegrations/microsoftteams/integration.py (Diff revision 13)
The issue has been resolved. Show all issues
```
No need for the parens around the ... is ....
```

rbintegrations/microsoftteams/integration.py (Diff revision 13)

The issue has been resolved. Show all issues

We should use format_html(), since it's safer (the arguments going in will be HTML-escaped).

rbintegrations/microsoftteams/integration.py (Diff revision 13)
The issue has been resolved. Show all issues
```
This should use .copy() instead of dict(...).
```
rbintegrations/microsoftteams/integration.py (Diff revision 13)
The issue has been resolved. Show all issues
```
We standardize on lowercase utf-8.
```
1. hailan Dec. 18, 2020, 2:09 p.m.
  blah
2. hailan Dec. 18, 2020, 2:10 p.m.
  Oops, I thought this was localhost XD
rbintegrations/microsoftteams/integration.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Docstring summaries must be one line without wrapping.
```

Change Summary:

Address feedbacks

Commits:

	Summary	ID	Author
	Microsoft Teams Integration Option	5b8cfb6111e99ac52f5570e53d83849cbadd1ed3	HailanXyouknow
	Microsoft Teams Integration Option	fd6fe6409a66b76ca6d933ae842651a12fcbe6d8	HailanXyouknow

Diff:

Revision 14 (+3498)

Show changes

	rbintegrations/extension.py
	rbintegrations/msteams/__init__.py
	rbintegrations/msteams/forms.py
	rbintegrations/msteams/integration.py
	rbintegrations/msteams/tests.py
	rbintegrations/static/images/msteams/icon.png
	rbintegrations/static/images/msteams/icon@2x.png

Checks run (2 succeeded)

flake8 passed.

JSHint passed.