hailan got a fish trophy!
Change 'Ship It!' color 'success' to 'good' for chat integrations
Review Request #11211 — Created Oct. 8, 2020 and updated
Currently, when reviewers select the "Ship It!" option, the notification sent
to Slack has a bar that is colored grey. I found that a value of 'success'
is passed to color. Upon investigation it seems that Slack and Mattermost
doesn't understand what color corresponds to 'success'. However, it knows
'good' corresponds to green.
Evidence that Mattermost uses ‘good’ and not ‘success’:
Evidence that Slack uses ‘good’:
- I ran the unit tests on Slack and Mattermost. Two unrelated tests are failing
because they cannot find
/var/folders/.... See #integrations
- Confirmed that "Ship It!" message has a green bar instead of a grey one in
Slack and Mattermost for Review Board version 3.0 and 4.0 after the change