Add manual trigger UI for CircleCI integration.

Review Request #11208 — Created Oct. 1, 2020 and updated

MarcusBoay
rbintegrations
master
rbintegrations

Add manual trigger UI for CircleCI integration.

This change adds the ability for Integrations to run CircleCI manually.
A checkbox is added to the CircleCI form that indicates if CircleCI should only
run manually.

Watch the demo video here

Based on work by David Trowbridge: /r/11130

This patch depends on /r/11190, /r/11198 and /r/11204

Manual testing by adding a private GitHub repository with CircleCI integration,
checking and unchecking the "manually run" form checkbox to ensure that no
automated runs and done when a review request is made, and clicking the "Run"
button on the review request page.

Unit tests have been written to verify that when the configuration is set,
the CircleCI request is not made. Another test to verify that a build is
run when the signal is emitted.

Summary
Add manual trigger UI for CircleCI integration.
Add unit test for CircleCI manual run only.
Refactor CircleCI integration code to reduce duplication.
Fix CircleCI diffset and add more tests.
Description From Last Updated

W293 blank line contains whitespace

reviewbotreviewbot
MarcusBoay
MarcusBoay
MarcusBoay
Review request changed

Change Summary:

Finalize this patch from [WIP] with unit tests

Summary:

-[WIP] Add manual trigger UI for CircleCI integration.
+Add manual trigger UI for CircleCI integration.

Description:

~  

[WIP] Add manual trigger UI for CircleCI integration.

  ~

Add manual trigger UI for CircleCI integration.

   
   

This change adds the ability for Integrations to run CircleCI manually.

    A checkbox is added to the CircleCI form that indicates if CircleCI should only
    run manually.

   
   

Based on work by David Trowbridge: /r/11130

  +
  +

This patch depends on /r/11190 and /r/11198

  + for the unit tests to pass.

Testing Done:

   

Manual testing by adding a private GitHub repository with CircleCI integration,

    checking and unchecking the "manually run" form checkbox to ensure that no
    automated runs and done when a review request is made, and clicking the "Run"
    button on the review request page.

   
~  

Unit tests are TBD.

  ~

Unit test have been written to verify that when the configuration is set,

  + the CircleCI request is not made.

Commits:

Summary
-
Add manual trigger UI for CircleCI integration.
+
Add manual trigger UI for CircleCI integration.
+
Add unit test for CircleCI manual run only.

Diff:

Revision 3 (+454 -104)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

MarcusBoay
MarcusBoay
MarcusBoay
MarcusBoay
MarcusBoay
MarcusBoay
MarcusBoay
MarcusBoay
MarcusBoay
Review request changed

Change Summary:

Attached demo video in Description

Description:

   

Add manual trigger UI for CircleCI integration.

   
   

This change adds the ability for Integrations to run CircleCI manually.

    A checkbox is added to the CircleCI form that indicates if CircleCI should only
    run manually.

   
  +

Watch the demo video here

  +
   

Based on work by David Trowbridge: /r/11130

   
   

This patch depends on /r/11190, /r/11198 and /r/11204

Loading...