Summary

Update the GitHub support to use the modern HTTP functionality.

Review Request #11200 — Created Sept. 24, 2020 and submitted Oct. 30, 2020, 2:22 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

~~11199~~

Blocks

11204

Reviewers

Groups

reviewboard

People

Description

This change redoes the GitHub code to use the modern HTTP support. For
compatibility, some legacy functions (api_get(), api_post(), and
api_delete()) remain as deprecated wrappers, but all internal code is
now updated to use the standard HTTP functions. This will make the code
more maintainable going forward.

Testing Done

Unit tests pass on Python 2.7, 3.6, 3.7, and 3.8.

Commits

Summary	ID
Update the GitHub support to use the modern HTTP functionality. The GitHub backend has been wrapping the legacy JSON HTTP functions for years now. Review Board 4.0 introduced new HTTP functionality that standardizes error handling, post-request handling, header access, and more, which was largely based off the needs from the GitHub support. Until now, though, GitHub has retained its own implementation. This change redoes the GitHub code to use the modern HTTP support. For compatibility, some legacy functions (`api_get()`, `api_post()`, and `api_delete()`) remain as deprecated wrappers, but all internal code is now updated to use the standard HTTP functions. This will make the code more maintainable going forward.	ed0ddf3f341e329efc6290e4743a5bf4e67c5963

Summary

Update the GitHub support to use the modern HTTP functionality.

The GitHub backend has been wrapping the legacy JSON HTTP functions for years now. Review Board 4.0 introduced new HTTP functionality that standardizes error handling, post-request handling, header access, and more, which was largely based off the needs from the GitHub support. Until now, though, GitHub has retained its own implementation. This change redoes the GitHub code to use the modern HTTP support. For compatibility, some legacy functions (`api_get()`, `api_post()`, and `api_delete()`) remain as deprecated wrappers, but all internal code is now updated to use the standard HTTP functions. This will make the code more maintainable going forward.

ed0ddf3f341e329efc6290e4743a5bf4e67c5963

Issues

Description	From	Last Updated
E722 do not use bare except'	reviewbot	Sept. 24, 2020, 1:07 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E722 do not use bare except'
```

Change Summary:

Fixed a bare except:.

Commits:

	Summary	ID
	Update the GitHub support to use the modern HTTP functionality. The GitHub backend has been wrapping the legacy JSON HTTP functions for years now. Review Board 4.0 introduced new HTTP functionality that standardizes error handling, post-request handling, header access, and more, which was largely based off the needs from the GitHub support. Until now, though, GitHub has retained its own implementation. This change redoes the GitHub code to use the modern HTTP support. For compatibility, some legacy functions (`api_get()`, `api_post()`, and `api_delete()`) remain as deprecated wrappers, but all internal code is now updated to use the standard HTTP functions. This will make the code more maintainable going forward.	09e51266309f33cf48f8e0274fcba82defa1364e
	Update the GitHub support to use the modern HTTP functionality. The GitHub backend has been wrapping the legacy JSON HTTP functions for years now. Review Board 4.0 introduced new HTTP functionality that standardizes error handling, post-request handling, header access, and more, which was largely based off the needs from the GitHub support. Until now, though, GitHub has retained its own implementation. This change redoes the GitHub code to use the modern HTTP support. For compatibility, some legacy functions (`api_get()`, `api_post()`, and `api_delete()`) remain as deprecated wrappers, but all internal code is now updated to use the standard HTTP functions. This will make the code more maintainable going forward.	ed0ddf3f341e329efc6290e4743a5bf4e67c5963

Depends On:

+	~~11199 - Add header normalization and fetching for hosting service HTTP support.~~

Diff:

Revision 2 (+264 -274)

Show changes

reviewboard/hostingsvcs/github.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (4310631)