Fix more errors in Review Bot configuration pages.

Review Request #11194 — Created Sept. 21, 2020 and submitted

Information

ReviewBot
release-2.0.x

Reviewers

This makes two changes to fix additional errors in the Review Bot config
process.

First, the integration config form was still encountering issues with
client-side validation of hidden tool options input elements on some
versions of Chrome. Instead of going through and making each element
disabled, I've changed it to just set novalidate on the top-level
form.

Second, I noticed that there was an error in the JS console when loading
the extension configuration page. This was due to the template
overriding the scripts-post block but not including the block's super,
leaving out some necessary JS files.

Exercised the extension and integration config pages.

Summary ID
Fix more errors in Review Bot configuration pages.
This makes two changes to fix additional errors in the Review Bot config process. First, the integration config form was still encountering issues with client-side validation of hidden tool options input elements on some versions of Chrome. Instead of going through and making each element disabled, I've changed it to just set `novalidate` on the top-level form. Second, I noticed that there was an error in the JS console when loading the extension configuration page. This was due to the template overriding the `scripts-post` block but not including the block's super, leaving out some necessary JS files. Testing Done: Exercised the extension and integration config pages.
e81c40e1315dc2878d13c9235f35298f42cfa5de
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (67fbfe6)