Summary

Use Celery 4.x when running on Python 3

Review Request #11188 — Created Sept. 19, 2020 and submitted Sept. 20, 2020, 8:12 a.m.

Information

Owner

david

Repository

ReviewBot

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

This change makes us conditionally use Celery 4.x when running on Python
3, and Celery 3.x when on Python 2.7. The 3.x version is pinned to
3.1.25 or newer, which introduces a forward-compatible wire protocol
with 4.x. We therefore end up with this support matrix:

RB | Python | Django | Celery
------+--------+--------+------------
3.0.x | 2.7 | 1.6 | 3.1.25+, <4
4.0.x | 2.7 | 1.11 | 3.1.25+, <4
4.0.x | 3.6+ | 1.11 | 4.4+, <5

Testing Done

Configured and ran Review Bot with the server and worker running on
both Python 2.7 and 3.8. Saw that it worked with both the 3.1.25 and
4.4.7 versions of Celery.

Commits

Summary	ID
Use Celery 4.x when running on Python 3 The support matrix between versions of Celery, Django, and Review Board is tricky and complex. Celery 3.x, the version we were on, doesn't support running on Python 3. Celery 4.x, which does support Python 3, doesn't support Django 1.6. This change makes us conditionally use Celery 4.x when running on Python 3, and Celery 3.x when on Python 2.7. The 3.x version is pinned to 3.1.25 or newer, which introduces a forward-compatible wire protocol with 4.x. We therefore end up with this support matrix: RB \| Python \| Django \| Celery ------+--------+--------+------------ 3.0.x \| 2.7 \| 1.6 \| 3.1.25+, <4 4.0.x \| 2.7 \| 1.11 \| 3.1.25+, <4 4.0.x \| 3.6+ \| 1.11 \| 4.4+, <5 Testing Done: Configured and ran Review Bot with the server and worker running on both Python 2.7 and 3.8. Saw that it worked with both the 3.1.25 and 4.4.7 versions of Celery.	67122ec7c7d25114058be7a381f1b066775513fa

Summary

Use Celery 4.x when running on Python 3

The support matrix between versions of Celery, Django, and Review Board is tricky and complex. Celery 3.x, the version we were on, doesn't support running on Python 3. Celery 4.x, which does support Python 3, doesn't support Django 1.6. This change makes us conditionally use Celery 4.x when running on Python 3, and Celery 3.x when on Python 2.7. The 3.x version is pinned to 3.1.25 or newer, which introduces a forward-compatible wire protocol with 4.x. We therefore end up with this support matrix: RB | Python | Django | Celery ------+--------+--------+------------ 3.0.x | 2.7 | 1.6 | 3.1.25+, <4 4.0.x | 2.7 | 1.11 | 3.1.25+, <4 4.0.x | 3.6+ | 1.11 | 4.4+, <5 Testing Done: Configured and ran Review Bot with the server and worker running on both Python 2.7 and 3.8. Saw that it worked with both the 3.1.25 and 4.4.7 versions of Celery.

67122ec7c7d25114058be7a381f1b066775513fa

Issues

Description	From	Last Updated
You can just do "2.7".	chipx86	Sept. 19, 2020, 4:20 p.m.
You can just do "2.7".	chipx86	Sept. 19, 2020, 4:20 p.m.

flake8 passed.

JSHint passed.

That was a smaller change than I expected.

bot/setup.py (Diff revision 1)
Show all issues
```
You can just do "2.7".
```
extension/setup.py (Diff revision 1)
Show all issues
```
You can just do "2.7".
```

Commits:

	Summary	ID
	Use Celery 4.x when running on Python 3 The support matrix between versions of Celery, Django, and Review Board is tricky and complex. Celery 3.x, the version we were on, doesn't support running on Python 3. Celery 4.x, which does support Python 3, doesn't support Django 1.6. This change makes us conditionally use Celery 4.x when running on Python 3, and Celery 3.x when on Python 2.7. The 3.x version is pinned to 3.1.25 or newer, which introduces a forward-compatible wire protocol with 4.x. We therefore end up with this support matrix: RB \| Python \| Django \| Celery ------+--------+--------+----------- 3.0.x \| 2.7 \| 1.6 \| 3.1.25+, <4 4.0.x \| 2.7 \| 1.11 \| 3.1.25+, <4 4.0.x \| 3.6+ \| 1.11 \| 4.4+, <5 Testing Done: Configured and ran Review Bot with the server and worker running on both Python 2.7 and 3.8. Saw that it worked with both the 3.1.25 and 4.4.7 versions of Celery.	7043aab68116b1bc2d923dd8ce063d50d6040116
	Use Celery 4.x when running on Python 3 The support matrix between versions of Celery, Django, and Review Board is tricky and complex. Celery 3.x, the version we were on, doesn't support running on Python 3. Celery 4.x, which does support Python 3, doesn't support Django 1.6. This change makes us conditionally use Celery 4.x when running on Python 3, and Celery 3.x when on Python 2.7. The 3.x version is pinned to 3.1.25 or newer, which introduces a forward-compatible wire protocol with 4.x. We therefore end up with this support matrix: RB \| Python \| Django \| Celery ------+--------+--------+------------ 3.0.x \| 2.7 \| 1.6 \| 3.1.25+, <4 4.0.x \| 2.7 \| 1.11 \| 3.1.25+, <4 4.0.x \| 3.6+ \| 1.11 \| 4.4+, <5 Testing Done: Configured and ran Review Bot with the server and worker running on both Python 2.7 and 3.8. Saw that it worked with both the 3.1.25 and 4.4.7 versions of Celery.	67122ec7c7d25114058be7a381f1b066775513fa

Diff:

Revision 2 (+60 -16)

Show changes

	bot/setup.py
	bot/reviewbot/celery.py
	extension/setup.py
	extension/reviewbotext/extension.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (cb09372)

bot/setup.py (Diff revision 1)

extension/setup.py (Diff revision 1)