Summary

Work around Chrome's over-eager validation of integration config form.

Review Request #11184 — Created Sept. 19, 2020 and submitted Sept. 19, 2020, 3:35 p.m.

Information

Owner

david

Repository

ReviewBot

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

Chrome loves to test the validation of forms, even going so far as to
run validation on inputs which are not visible to the user. It then
errors out on the console that it can't focus the input. This change
goes through and adds the disabled prop to any tool option inputs
which are hidden (because they don't apply to the currently-selected
tool), working around the validation on the client.

Testing Done

Was able to create an integration config for Review Bot without Chrome
going nuts.

Commits

Summary	ID
Work around Chrome's over-eager validation of integration config form. Chrome loves to test the validation of forms, even going so far as to run validation on inputs which are not visible to the user. It then errors out on the console that it can't focus the input. This change goes through and adds the `disabled` prop to any tool option inputs which are hidden (because they don't apply to the currently-selected tool), working around the validation on the client. Testing Done: Was able to create an integration config for Review Bot without Chrome going nuts.	df187f5994fe41c9e380266486127ee992a06868

Summary

Work around Chrome's over-eager validation of integration config form.

Chrome loves to test the validation of forms, even going so far as to run validation on inputs which are not visible to the user. It then errors out on the console that it can't focus the input. This change goes through and adds the `disabled` prop to any tool option inputs which are hidden (because they don't apply to the currently-selected tool), working around the validation on the client. Testing Done: Was able to create an integration config for Review Bot without Chrome going nuts.

df187f5994fe41c9e380266486127ee992a06868

Issues

Description	From	Last Updated
Can we add a comma after each space?	chipx86	Sept. 19, 2020, 3:34 p.m.

flake8 passed.

JSHint passed.

Ship it!

It'll be really nice when we can move this to the new subform support in Review Board 4.0.

extension/reviewbotext/static/js/integrationConfig.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we add a comma after each space?
```
1. david Sept. 19, 2020, 3:34 p.m.
  Guessing you meant a space after each comma :)

Status:: Completed
Change Summary:: Pushed to release-2.0.x (3eb5516)