Summary

Fix loading of configform-provided JS/CSS bundles.

Review Request #11183 — Created Sept. 19, 2020 and submitted Sept. 19, 2020, 4:14 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Review Board's new template for rendering configforms (overriding
djblets' version) wasn't loading form-provided JS or CSS bundles. This
change adds that back in.

Testing Done

Loaded the Review Bot integration config form and saw that the
associated JavaScript was included in the page.

Commits

Summary	ID
Fix loading of configform-provided JS/CSS bundles. Review Board's new template for rendering configforms (overriding djblets' version) wasn't loading form-provided JS or CSS bundles. This change adds that back in. Testing Done: Loaded the Review Bot integration config form and saw that the associated JavaScript was included in the page.	f02c75e56f5f720015f97ef299dab903638fdfb0

Issues

Description	From	Last Updated
Need to indent one more level.	chipx86	Sept. 19, 2020, 3:25 p.m.
Same here.	chipx86	Sept. 19, 2020, 3:25 p.m.
We already call this above.	chipx86	Sept. 19, 2020, 3:25 p.m.

flake8 passed.

JSHint passed.

reviewboard/templates/admin/change_form.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Need to indent one more level.
```
reviewboard/templates/admin/change_form.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
reviewboard/templates/admin/change_form.html (Diff revision 1)
The issue has been resolved. Show all issues
```
We already call this above.
```

Commits:

	Summary	ID
	Fix loading of configform-provided JS/CSS bundles. Review Board's new template for rendering configforms (overriding djblets' version) wasn't loading form-provided JS or CSS bundles. This change adds that back in. Testing Done: Loaded the Review Bot integration config form and saw that the associated JavaScript was included in the page.	79b77d73c511d72acf8cf7c992686c4861e68194
	Fix loading of configform-provided JS/CSS bundles. Review Board's new template for rendering configforms (overriding djblets' version) wasn't loading form-provided JS or CSS bundles. This change adds that back in. Testing Done: Loaded the Review Bot integration config form and saw that the associated JavaScript was included in the page.	f02c75e56f5f720015f97ef299dab903638fdfb0

Diff:

Revision 2 (+18 -2)

Show changes

reviewboard/templates/admin/change_form.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (cdad7d9)