Updated Djblets' ListItemView to use the correct CSS class

Review Request #11178 — Created Sept. 18, 2020 and submitted

jblazusi
Djblets
release-2.0.x
4883
djblets, students

Updated Djblets' ListItemView to use the correct CSS class. More
specifically ListItemView was using djblets-c-config-forms-list-item
instead of djblets-c-config-forms-list__item.

I did not run any automated tests, instead I verified that the
change was successful by accessing fields where ListItemView was
being used. I manually verified that the correct CSS class was
being used with Google Chrome Developer Tools. Examples of
this were in Review Board's user preferences page, in sections
such as "Groups" or "Authentication > API Tokens".

Summary
Updated Djblets' ListItemView to use the correct CSS class ('djblets-c-config-forms-list-item' -> 'djblets-c-config-forms-list__item')
Description From Last Updated

The code change looks fine! The summary and description needs some love, though. The aim is to describe the high-level ...

chipx86chipx86
jblazusi
chipx86
  1. 
      
  2. The code change looks fine! The summary and description needs some love, though. The aim is to describe the high-level (not code-level) changes being made, so that a reviewer, or someone examining the code later, will know what problem occurred (how did this issue manifest itself?) and what the resolution was (fixing the typo, using the correct class name of djblets-c-config-forms-list__item).

    Look through our examples on Writing Good Change Descriptions.

    This also should wrap at 70-75 characters.

  3. 
      
jblazusi
david
  1. Ship It!
  2. 
      
jblazusi
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (7b96783)
Loading...