Summary

Updated Djblets' ListItemView to use the correct CSS class

Review Request #11178 — Created Sept. 18, 2020 and submitted Oct. 23, 2020, 1:30 p.m.

Information

Owner

jblazusi

Repository

Djblets

Branch

release-2.0.x

Bugs

4883

Depends On

Reviewers

Groups

djblets, students

People

Description

Updated Djblets' ListItemView to use the correct CSS class. More
specifically ListItemView was using djblets-c-config-forms-list-item
instead of djblets-c-config-forms-list__item.

Testing Done

I did not run any automated tests, instead I verified that the

change was successful by accessing fields where ListItemView was 

being used. I manually verified that the correct CSS class was 

being used with Google Chrome Developer Tools. Examples of 

this were in Review Board's user preferences page, in sections 

such as "Groups" or "Authentication > API Tokens".

Commits

Summary	ID
Updated Djblets' ListItemView to use the correct CSS class ('djblets-c-config-forms-list-item' -> 'djblets-c-config-forms-list__item')	33444a4ef0b814d215ed1e6388575cb766474da3

Issues

Description	From	Last Updated
The code change looks fine! The summary and description needs some love, though. The aim is to describe the high-level …	chipx86	Oct. 9, 2020, 3:52 p.m.

flake8 passed.

JSHint passed.

Bugs:: 4883
Groups:: students

The issue has been resolved. Show all issues

The code change looks fine! The summary and description needs some love, though. The aim is to describe the high-level (not code-level) changes being made, so that a reviewer, or someone examining the code later, will know what problem occurred (how did this issue manifest itself?) and what the resolution was (fixing the typo, using the correct class name of djblets-c-config-forms-list__item).
Look through our examples on Writing Good Change Descriptions.
This also should wrap at 70-75 characters.

Change Summary:: Gave the summary and the description some more love!
Summary:: Updated Djblets' ListItemView to use the correct CSS class ('djblets-c-config-forms-list-item' -> 'djblets-c-config-forms-list__item')
Updated Djblets' ListItemView to use the correct CSS class
Description:: ~
Updated Djblets' ListItemView to use the correct CSS class ('djblets-c-config-forms-list-item' -> 'djblets-c-config-forms-list__item')
~
Updated Djblets' ListItemView to use the correct CSS class. More
+ specifically ListItemView was using djblets-c-config-forms-list-item
+ instead of djblets-c-config-forms-list__item.
Testing Done:: ~
I changed the ListItemView CSS class and verified that it has been updated by attempting to replicate the bug.
~
I did not run any automated tests, instead I verified that the
+ change was successful by accessing fields where ListItemView was
+ being used. I manually verified that the correct CSS class was
+ being used with Google Chrome Developer Tools. Examples of
+ this were in Review Board's user preferences page, in sections
+ such as "Groups" or "Authentication > API Tokens".

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (7b96783)

~		Updated Djblets' ListItemView to use the correct CSS class ('djblets-c-config-forms-list-item' -> 'djblets-c-config-forms-list__item')
	~	Updated Djblets' `ListItemView` to use the correct CSS class. More
	+	specifically `ListItemView` was using `djblets-c-config-forms-list-item`
	+	instead of `djblets-c-config-forms-list__item`.

~		I changed the ListItemView CSS class and verified that it has been updated by attempting to replicate the bug.
	~	I did not run any automated tests, instead I verified that the
	+	change was successful by accessing fields where `ListItemView` was
	+	being used. I manually verified that the correct CSS class was
	+	being used with Google Chrome Developer Tools. Examples of
	+	this were in Review Board's user preferences page, in sections
	+	such as "Groups" or "Authentication > API Tokens".