updated styling for security container
Review Request #11175 — Created Sept. 18, 2020 and discarded
Information | |
---|---|
ruonanjia | |
Review Board | |
master | |
4881 | |
Reviewers | |
reviewboard, students | |
This change makes the styling for the security page more consistent with
the other pages.Uses rounded borders with white background instead of black solid border.
Manually tested that styles are updated and looking correct when running
reviewboard locally.
Summary | Author |
---|---|
ruonan |
Description | From | Last Updated |
---|---|---|
Can you take a screenshot of the updated page and attach it using "Update > Add File"? |
|
|
Please see https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea for info on how we'd like to see the summary/description written. |
|
|
The lines in Description and Testing Done are more than 70 characters ;) |
|
|
For your summary, please capitalize the first letter. |
|
|
The first line of your description can be removed, since it's the same as your summary. Please also add punctuation … |
|
|
Mind uploading a new version of the screenshot so we can see what it looks like now? |
|
|
The posted diff has a bunch of unrelated stuff. Please pull the latest master and rebase your change. |
|
|
We didn't used to have a lot of standards around the way things looked in the admin UI (historical technical … |
|
|
"form-row" is considered a legacy class, so we should probably stop using it. There are newer classes for lists of … |
|
|
Please switch these so they're in alphabetical order. |
|
|
Because you removed one level of the tags here, you'll need to dedent the <ul> and everything inside it by … |
|
Description: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
Description: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||
Diff: |
Revision 2 (+4 -4) |
||||||||||||||||||
Added Files: |
Checks run (2 succeeded)
Description: |
|
---|
-
-
We didn't used to have a lot of standards around the way things looked in the admin UI (historical technical reasons for that). We can do better now, and really clean this up. A few things immediately stand out here:
- Too much padding around this, compared to other pages. Likely coming from the existing security center classes, or default element styles. We can probably fix this up by adding some better rules for the classes being used.
- There's a max width enforced, but there's not much reason for that. Let's get rid of that.
- It'd be nice to have that indented part have the same level of "indentation" as the outer container, once the above is fixed up. We actually have LessCSS constants for all this, so we can keep things nice and consistent.
-
reviewboard/templates/admin/security.html (Diff revision 2) "form-row" is considered a legacy class, so we should probably stop using it. There are newer classes for lists of items, like what's used in the Extensions or Integrations pages, and it might be interesting to see how it looks using those.
Commits: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+13 -9) |
Checks run (2 succeeded)
Commits: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+12 -14) |
Checks run (2 succeeded)
Description: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
-
-
-
The first line of your description can be removed, since it's the same as your summary. Please also add punctuation to the description and testing done.
-
-
reviewboard/static/rb/css/pages/admin/security-center.less (Diff revision 4) Please switch these so they're in alphabetical order.
-
reviewboard/templates/admin/security.html (Diff revision 4) Because you removed one level of the tags here, you'll need to dedent the
<ul>
and everything inside it by one space.
Description: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||||||||||||||
Commits: |
|
||||||||||||||||||||||||||||||||||||
Branch: |
|
||||||||||||||||||||||||||||||||||||
Diff: |
Revision 5 (+186 -463) |
Checks run (2 succeeded)
Commits: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+210 -485) |