flake8
passed.
JSHint
passed.
updated styling for security container
Review Request #11175 — Created Sept. 18, 2020 and discarded
This change makes the styling for the security page more consistent with
the other pages.Uses rounded borders with white background instead of black solid border.
Manually tested that styles are updated and looking correct when running
reviewboard locally.
| Summary | ID | Author |
|---|---|---|
| c7c000aed3e5d4a8f0a2a3110d0cd97b0512bcd0 | ruonan |
| Description | From | Last Updated |
|---|---|---|
|
Can you take a screenshot of the updated page and attach it using "Update > Add File"? |
 david
|
|
|
Please see https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea for info on how we'd like to see the summary/description written. |
david
|
|
|
The lines in Description and Testing Done are more than 70 characters ;) |
 hailan
|
|
|
For your summary, please capitalize the first letter. |
david
|
|
|
The first line of your description can be removed, since it's the same as your summary. Please also add punctuation … |
david
|
|
|
Mind uploading a new version of the screenshot so we can see what it looks like now? |
david
|
|
|
The posted diff has a bunch of unrelated stuff. Please pull the latest master and rebase your change. |
david
|
|
|
We didn't used to have a lot of standards around the way things looked in the admin UI (historical technical … |
 chipx86
|
|
|
"form-row" is considered a legacy class, so we should probably stop using it. There are newer classes for lists of … |
chipx86
|
|
|
Please switch these so they're in alphabetical order. |
david
|
|
|
Because you removed one level of the tags here, you'll need to dedent the <ul> and everything inside it by … |
david
|
- Groups:
- Description:
-
~ updated styling for security container to match new styles at path admin/security
~ updated styling for security center to match other pages
+ + switched fieldset to a div with classNames using new styles
- Testing Done:
-
+ Manually tested that styles are updated and looking right when running reviewboard locally
- Description:
-
~ updated styling for security center to match other pages
~ Updated styling for security center
+ + This change makes the styling for the security page more consistent with the other pages
+ + It uses rounded borders with white background instead of black solid border
- Commits:
-
Summary ID Author 0993395494fc1bf8e3b18a37cad3037f271fd4f0 ruonan f9bbb614c77d039619b6b2775ad93adf302edcc9 ruonan - Added Files:
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Description:
-
Updated styling for security center
This change makes the styling for the security page more consistent with the other pages
~ It uses rounded borders with white background instead of black solid border
~ Uses rounded borders with white background instead of black solid border
-
-
We didn't used to have a lot of standards around the way things looked in the admin UI (historical technical reasons for that). We can do better now, and really clean this up. A few things immediately stand out here:
- Too much padding around this, compared to other pages. Likely coming from the existing security center classes, or default element styles. We can probably fix this up by adding some better rules for the classes being used.
- There's a max width enforced, but there's not much reason for that. Let's get rid of that.
- It'd be nice to have that indented part have the same level of "indentation" as the outer container, once the above is fixed up. We actually have LessCSS constants for all this, so we can keep things nice and consistent.
-
"form-row" is considered a legacy class, so we should probably stop using it. There are newer classes for lists of items, like what's used in the Extensions or Integrations pages, and it might be interesting to see how it looks using those.
- Commits:
-
Summary ID Author f9bbb614c77d039619b6b2775ad93adf302edcc9 ruonan f9bbb614c77d039619b6b2775ad93adf302edcc9 ruonan 2abb29027e726c88614dfbb842ac3e4c7b5aab36 ruonan
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commits:
-
Summary ID Author f9bbb614c77d039619b6b2775ad93adf302edcc9 ruonan 2abb29027e726c88614dfbb842ac3e4c7b5aab36 ruonan f9bbb614c77d039619b6b2775ad93adf302edcc9 ruonan 2abb29027e726c88614dfbb842ac3e4c7b5aab36 ruonan 2658ed6681c29c8c1c7cc2eb01e8bcb10f595bbf ruonan
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Description:
-
Updated styling for security center
~ This change makes the styling for the security page more consistent with the other pages
~ + + This change makes the styling for the security page more consistent with
+ the other pages + + Uses rounded borders with white background instead of black solid border
- Testing Done:
-
~ Manually tested that styles are updated and looking right when running reviewboard locally
~ Manually tested that styles are updated and looking right when running
+ reviewboard locally
- Description:
-
- Updated styling for security center
- - - This change makes the styling for the security page more consistent with
~ the other pages ~ the other pages. - - ~ Uses rounded borders with white background instead of black solid border
~ Uses rounded borders with white background instead of black solid border.
- Testing Done:
-
~ Manually tested that styles are updated and looking right when running
~ reviewboard locally ~ Manually tested that styles are updated and looking correct when running
~ reviewboard locally. - Commits:
-
Summary ID Author f9bbb614c77d039619b6b2775ad93adf302edcc9 ruonan 2abb29027e726c88614dfbb842ac3e4c7b5aab36 ruonan 2658ed6681c29c8c1c7cc2eb01e8bcb10f595bbf ruonan 583be5c72ec924f674d860bcb905626242386aba ruonan 714c659cd0d98eb3ce0f6cc2979bb098017dc7c7 ruonan - Branch:
-
release-4.0.xmaster
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commits:
-
Summary ID Author 583be5c72ec924f674d860bcb905626242386aba ruonan 714c659cd0d98eb3ce0f6cc2979bb098017dc7c7 ruonan c7c000aed3e5d4a8f0a2a3110d0cd97b0512bcd0 ruonan
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.