Summary

Add a patch for fixing broken db_indexes on MySQL on Django 1.8-1.10.

Review Request #11172 — Created Sept. 14, 2020 and submitted Oct. 30, 2020, 3:27 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

The MySQL backend on Django 1.8 through 1.10 has a heavy-handed
workaround for some of its SQL generation around indexes. It tries to
disable setting indexes on a ForeignKey, leaving that up to MySQL
itself, by setting db_index = False. It claims this is "temporary,"
but it never restores the values. This impacts signatures of these
fields on these versions of Django (and breaks unit tests).

This patch preserves the list of fields that would have their values
reset and then restores db_index on each of them, allowing Django to
continue to avoid those indexes without breaking any future usage of
the flags on these fields.

Testing Done

MySQL unit tests pass on all supported versions of Django.

Commits

Summary	ID
Add a patch for fixing broken db_indexes on MySQL on Django 1.8-1.10. The MySQL backend on Django 1.8 through 1.10 has a heavy-handed workaround for some of its SQL generation around indexes. It tries to disable setting indexes on a `ForeignKey`, leaving that up to MySQL itself, by setting `db_index = False`. It claims this is "temporary," but it never restores the values. This impacts signatures of these fields on these versions of Django (and breaks unit tests). This patch preserves the list of fields that would have their values reset and then restores `db_index` on each of them, allowing Django to continue to avoid those indexes without breaking any future usage of the flags on these fields.	97c826c943ed019fdce067dcf0e7aaf72fa38b99

Summary

Add a patch for fixing broken db_indexes on MySQL on Django 1.8-1.10.

The MySQL backend on Django 1.8 through 1.10 has a heavy-handed workaround for some of its SQL generation around indexes. It tries to disable setting indexes on a `ForeignKey`, leaving that up to MySQL itself, by setting `db_index = False`. It claims this is "temporary," but it never restores the values. This impacts signatures of these fields on these versions of Django (and breaks unit tests). This patch preserves the list of fields that would have their values reset and then restores `db_index` on each of them, allowing Django to continue to avoid those indexes without breaking any future usage of the flags on these fields.

97c826c943ed019fdce067dcf0e7aaf72fa38b99

Issues

Description	From	Last Updated
E999 SyntaxError: invalid syntax	reviewbot	Sept. 14, 2020, 9:05 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/compat/patches/django1_8__1_10_mysql_preserve_db_index.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E999 SyntaxError: invalid syntax
```

Change Summary:

Fixed a typo that snuck into the commit.

Commits:

	Summary	ID
	Add a patch for fixing broken db_indexes on MySQL on Django 1.8-1.10. The MySQL backend on Django 1.8 through 1.10 has a heavy-handed workaround for some of its SQL generation around indexes. It tries to disable setting indexes on a `ForeignKey`, leaving that up to MySQL itself, by setting `db_index = False`. It claims this is "temporary," but it never restores the values. This impacts signatures of these fields on these versions of Django (and breaks unit tests). This patch preserves the list of fields that would have their values reset and then restores `db_index` on each of them, allowing Django to continue to avoid those indexes without breaking any future usage of the flags on these fields.	1b46d20b53a1e853bd2c4c6ccc941f1a6eb92eb6
	Add a patch for fixing broken db_indexes on MySQL on Django 1.8-1.10. The MySQL backend on Django 1.8 through 1.10 has a heavy-handed workaround for some of its SQL generation around indexes. It tries to disable setting indexes on a `ForeignKey`, leaving that up to MySQL itself, by setting `db_index = False`. It claims this is "temporary," but it never restores the values. This impacts signatures of these fields on these versions of Django (and breaks unit tests). This patch preserves the list of fields that would have their values reset and then restores `db_index` on each of them, allowing Django to continue to avoid those indexes without breaking any future usage of the flags on these fields.	97c826c943ed019fdce067dcf0e7aaf72fa38b99

Diff:

Revision 2 (+126)

Show changes

	django_evolution/compat/patches/__init__.py
	django_evolution/compat/patches/django1_8__1_10_mysql_preserve_db_index.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (a7d5474)