Summary

Enhance and fix up the setup experience in prepare-dev.py.

Review Request #11162 — Created Sept. 19, 2020 and submitted Sept. 19, 2020, 2:40 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This modernizes the way we request input and display output on
prepare-dev.py, utilizing more of rb-site's ConsoleUI. This is a
better, more consistent way of displaying information and prompting for
information.

The text has been updated to be more user-friendly, to offer
guidance for when things go wrong, and to provide next steps when the
environment is prepared.

Testing Done

Ran through prepare-dev.py. Saw that I got all the nice text UI
enhancements and string changes.

Commits

Summary	ID
Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	722f632584e23d8f9c0e37eab84ffc9ed730fb32

Summary

Enhance and fix up the setup experience in prepare-dev.py.

This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.

722f632584e23d8f9c0e37eab84ffc9ed730fb32

Issues

Description	From	Last Updated
F401 'django.utils.six' imported but unused	reviewbot	Sept. 19, 2020, 10:53 a.m.
F841 local variable 'page' is assigned to but never used	reviewbot	Sept. 19, 2020, 10:53 a.m.
There are two spaces between "in" and "the"	david	Sept. 19, 2020, 2:34 p.m.
Please use single quotes instead of double.	david	Sept. 19, 2020, 2:34 p.m.
Please put a blank line between the previous block and the next line.	david	Sept. 19, 2020, 2:34 p.m.
Missing a space at the end of the first line.	david	Sept. 19, 2020, 2:34 p.m.

flake8 failed.

JSHint passed.

flake8

contrib/internal/prepare-dev.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.utils.six' imported but unused
```
contrib/internal/prepare-dev.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'page' is assigned to but never used
```

Change Summary:

Fixed an unused variable and import.

Commits:

	Summary	ID
	Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	327f3f0d091112eee133e3c38ff236afe09eed60
	Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	2f914bcbca1a6a075cd4350f5b0b80b1a644d83d

Diff:

Revision 2 (+134 -44)

Show changes

contrib/internal/prepare-dev.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	2f914bcbca1a6a075cd4350f5b0b80b1a644d83d
	Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	68f2fcb5eeeab76c2fc11080ca69bc568acf97dd

Diff:

Revision 3 (+132 -46)

Show changes

contrib/internal/prepare-dev.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Looking pretty good, just a few small style questions.

contrib/internal/prepare-dev.py (Diff revision 3)
The issue has been resolved. Show all issues
```
There are two spaces between "in" and "the"
```

contrib/internal/prepare-dev.py (Diff revision 3)

What does os.system do?

chipx86 Sept. 19, 2020, 2:35 p.m.

It's used to execute processes, similar to running a command in a shell. It's not always the right approach — the subprocess module is sometimes the better solution here.

contrib/internal/prepare-dev.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Please use single quotes instead of double.
```
contrib/internal/prepare-dev.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Please put a blank line between the previous block and the next line.
```
contrib/internal/prepare-dev.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing a space at the end of the first line.
```

Change Summary:


Fixed some stylistic issues with blank lines.
Fixed extra spaces in strings, and added missing spaces in others.
Switched to single quotes from double quotes in a string.

Commits:

	Summary	ID
	Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	68f2fcb5eeeab76c2fc11080ca69bc568acf97dd
	Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	722f632584e23d8f9c0e37eab84ffc9ed730fb32

Diff:

Revision 4 (+134 -44)

Show changes

contrib/internal/prepare-dev.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (aa92651)