Enhance and fix up the setup experience in prepare-dev.py.

Review Request #11162 — Created Sept. 19, 2020 and submitted

Information

Review Board
release-4.0.x

Reviewers

This modernizes the way we request input and display output on
prepare-dev.py, utilizing more of rb-site's ConsoleUI. This is a
better, more consistent way of displaying information and prompting for
information.

The text has been updated to be more user-friendly, to offer
guidance for when things go wrong, and to provide next steps when the
environment is prepared.

Ran through prepare-dev.py. Saw that I got all the nice text UI
enhancements and string changes.

Summary ID
Enhance and fix up the setup experience in prepare-dev.py.
This modernizes the way we request input and display output on `prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.
722f632584e23d8f9c0e37eab84ffc9ed730fb32
Description From Last Updated

F401 'django.utils.six' imported but unused

reviewbotreviewbot

F841 local variable 'page' is assigned to but never used

reviewbotreviewbot

There are two spaces between "in" and "the"

daviddavid

Please use single quotes instead of double.

daviddavid

Please put a blank line between the previous block and the next line.

daviddavid

Missing a space at the end of the first line.

daviddavid
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
chipx86
david
  1. Looking pretty good, just a few small style questions.

  2. contrib/internal/prepare-dev.py (Diff revision 3)
     
     
    Show all issues

    There are two spaces between "in" and "the"

  3. contrib/internal/prepare-dev.py (Diff revision 3)
     
     

    What does os.system do?

    1. It's used to execute processes, similar to running a command in a shell. It's not always the right approach — the subprocess module is sometimes the better solution here.

  4. contrib/internal/prepare-dev.py (Diff revision 3)
     
     
    Show all issues

    Please use single quotes instead of double.

  5. contrib/internal/prepare-dev.py (Diff revision 3)
     
     
     
    Show all issues

    Please put a blank line between the previous block and the next line.

  6. contrib/internal/prepare-dev.py (Diff revision 3)
     
     
     
    Show all issues

    Missing a space at the end of the first line.

  7. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (aa92651)