Fix remaining unicode issues in MercurialClient.get_commit_history.

 






 

 


  Review Request #11138
  —
  Created Aug. 12, 2020 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  release-2.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
The formatting fix I did earlier did work, but exposed more issues in

the get_commit_history method. Instead of juggling between bytes and

unicode strings here, it makes sense to do everything just in

unicode-land. The reason we had any bytestrings here was probably just

some over-eager changes when we did the initial porting work.

 








  


 
 

  
Added a new unit test which now passes on both Python 2.x and 3.x.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Fix remaining unicode issues in MercurialClient.get_commit_history.
     
The formatting fix I did earlier did work, but exposed more issues in
the `get_commit_history` method. Instead of juggling between bytes and
unicode strings here, it makes sense to do everything just in
unicode-land. The reason we had any bytestrings here was probably just
some over-eager changes when we did the initial porting work.

Testing Done:
Added a new unit test which now passes on both Python 2.x and 3.x.

    

   
  		
  d3380f82b17abbc4469b8ce5cc3bb92e44e03daa
  David Trowbridge
 


 
  
 
 
  
   
    

     Fix remaining unicode issues in MercurialClient.get_commit_history.
     
The formatting fix I did earlier did work, but exposed more issues in
the `get_commit_history` method. Instead of juggling between bytes and
unicode strings here, it makes sense to do everything just in
unicode-land. The reason we had any bytestrings here was probably just
some over-eager changes when we did the initial porting work.

Testing Done:
Added a new unit test which now passes on both Python 2.x and 3.x.

    

   
  		
  b2629d5bbdcacf77682f31039cf78e1f8dbdf302
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/mercurial.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...