flake8
passed.
JSHint
passed.
Fix remaining unicode issues in MercurialClient.get_commit_history.
Review Request #11138 — Created Aug. 12, 2020 and submitted
| Information | |
|---|---|
| david | |
| RBTools | |
| release-2.0.x | |
| Reviewers | |
| rbtools | |
The formatting fix I did earlier did work, but exposed more issues in
theget_commit_historymethod. Instead of juggling between bytes and
unicode strings here, it makes sense to do everything just in
unicode-land. The reason we had any bytestrings here was probably just
some over-eager changes when we did the initial porting work.
Added a new unit test which now passes on both Python 2.x and 3.x.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
I don't see anything in here that requires a r prefix. What's that for? |
 chipx86
|
-
-
rbtools/clients/mercurial.py (Diff revision 1) I don't see anything in here that requires a
rprefix. What's that for?
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+96 -36) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.