Summary

Fix remaining unicode issues in MercurialClient.get_commit_history.

Review Request #11138 — Created Aug. 12, 2020 and submitted Aug. 17, 2020, 8:28 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The formatting fix I did earlier did work, but exposed more issues in
the get_commit_history method. Instead of juggling between bytes and
unicode strings here, it makes sense to do everything just in
unicode-land. The reason we had any bytestrings here was probably just
some over-eager changes when we did the initial porting work.

Testing Done

Added a new unit test which now passes on both Python 2.x and 3.x.

Commits

Summary	ID
Fix remaining unicode issues in MercurialClient.get_commit_history. The formatting fix I did earlier did work, but exposed more issues in the `get_commit_history` method. Instead of juggling between bytes and unicode strings here, it makes sense to do everything just in unicode-land. The reason we had any bytestrings here was probably just some over-eager changes when we did the initial porting work. Testing Done: Added a new unit test which now passes on both Python 2.x and 3.x.	b2629d5bbdcacf77682f31039cf78e1f8dbdf302

Summary

Fix remaining unicode issues in MercurialClient.get_commit_history.

The formatting fix I did earlier did work, but exposed more issues in the `get_commit_history` method. Instead of juggling between bytes and unicode strings here, it makes sense to do everything just in unicode-land. The reason we had any bytestrings here was probably just some over-eager changes when we did the initial porting work. Testing Done: Added a new unit test which now passes on both Python 2.x and 3.x.

b2629d5bbdcacf77682f31039cf78e1f8dbdf302

Issues

Description	From	Last Updated
I don't see anything in here that requires a r prefix. What's that for?	chipx86	Aug. 14, 2020, 9:03 p.m.

flake8 passed.

JSHint passed.

rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I don't see anything in here that requires a r prefix. What's that for?
```
1. david Aug. 14, 2020, 9:03 p.m.
  Not sure. Fixing that up.

Commits:

	Summary	ID
	Fix remaining unicode issues in MercurialClient.get_commit_history. The formatting fix I did earlier did work, but exposed more issues in the `get_commit_history` method. Instead of juggling between bytes and unicode strings here, it makes sense to do everything just in unicode-land. The reason we had any bytestrings here was probably just some over-eager changes when we did the initial porting work. Testing Done: Added a new unit test which now passes on both Python 2.x and 3.x.	d3380f82b17abbc4469b8ce5cc3bb92e44e03daa
	Fix remaining unicode issues in MercurialClient.get_commit_history. The formatting fix I did earlier did work, but exposed more issues in the `get_commit_history` method. Instead of juggling between bytes and unicode strings here, it makes sense to do everything just in unicode-land. The reason we had any bytestrings here was probably just some over-eager changes when we did the initial porting work. Testing Done: Added a new unit test which now passes on both Python 2.x and 3.x.	b2629d5bbdcacf77682f31039cf78e1f8dbdf302

Diff:

Revision 2 (+96 -36)

Show changes

	rbtools/clients/mercurial.py
	rbtools/clients/tests/test_mercurial.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (5650e66)