Fix remaining unicode issues in MercurialClient.get_commit_history.

Review Request #11138 — Created Aug. 12, 2020 and submitted

Information

RBTools
release-2.0.x

Reviewers

The formatting fix I did earlier did work, but exposed more issues in
the get_commit_history method. Instead of juggling between bytes and
unicode strings here, it makes sense to do everything just in
unicode-land. The reason we had any bytestrings here was probably just
some over-eager changes when we did the initial porting work.

Added a new unit test which now passes on both Python 2.x and 3.x.

Summary ID
Fix remaining unicode issues in MercurialClient.get_commit_history.
The formatting fix I did earlier did work, but exposed more issues in the `get_commit_history` method. Instead of juggling between bytes and unicode strings here, it makes sense to do everything just in unicode-land. The reason we had any bytestrings here was probably just some over-eager changes when we did the initial porting work. Testing Done: Added a new unit test which now passes on both Python 2.x and 3.x.
b2629d5bbdcacf77682f31039cf78e1f8dbdf302
Description From Last Updated

I don't see anything in here that requires a r prefix. What's that for?

chipx86chipx86
chipx86
  1. 
      
  2. rbtools/clients/mercurial.py (Diff revision 1)
     
     
    Show all issues

    I don't see anything in here that requires a r prefix. What's that for?

    1. Not sure. Fixing that up.

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (5650e66)