Fix remaining unicode issues in MercurialClient.get_commit_history.

Review Request #11138 — Created Aug. 12, 2020 and submitted — Latest diff uploaded

Information

RBTools
release-2.0.x

Reviewers

The formatting fix I did earlier did work, but exposed more issues in
the get_commit_history method. Instead of juggling between bytes and
unicode strings here, it makes sense to do everything just in
unicode-land. The reason we had any bytestrings here was probably just
some over-eager changes when we did the initial porting work.

Added a new unit test which now passes on both Python 2.x and 3.x.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Fix remaining unicode issues in MercurialClient.get_commit_history.
The formatting fix I did earlier did work, but exposed more issues in the `get_commit_history` method. Instead of juggling between bytes and unicode strings here, it makes sense to do everything just in unicode-land. The reason we had any bytestrings here was probably just some over-eager changes when we did the initial porting work. Testing Done: Added a new unit test which now passes on both Python 2.x and 3.x.
d3380f82b17abbc4469b8ce5cc3bb92e44e03daa David Trowbridge
rbtools/clients/mercurial.py
rbtools/clients/tests/test_mercurial.py
Loading...