Summary

Improve Perforce SSL fingerprint parsing and error reporting.

Review Request #11126 — Created Aug. 6, 2020 and submitted Aug. 7, 2020, 10:29 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We now look for the fingerprint using a regex. We don't care where it is
in the string, so long as it's there somewhere.

Both that and the P4PORT get passed into the Certificate used for the
error message, which will then be displayed to the user.

Testing Done

Triggered the error with two kinds of SSL cert failures (one triggered
by no existing stored fingerprints for a server, one triggered by a new
fingerprint when an existing one was stored). Verified the error output
was correct in both cases.

Unit tests pass.

Commits

Summary	ID
Improve Perforce SSL fingerprint parsing and error reporting. The Perforce SSL error handling assumed some things about the placement of the fingerprint in the error message. This wasn't always correct, though. While this hasn't really been an issue in the past, practically speaking, it is now that we have improved unverified SSL certificate error. We now look for the fingerprint using a regex. We don't care where it is in the string, so long as it's there somewhere. Both that and the P4PORT get passed into the `Certificate` used for the error message, which will then be displayed to the user.	0bc2406a91fcab899eac76f52211f21be81e7be0

Summary

Improve Perforce SSL fingerprint parsing and error reporting.

The Perforce SSL error handling assumed some things about the placement of the fingerprint in the error message. This wasn't always correct, though. While this hasn't really been an issue in the past, practically speaking, it is now that we have improved unverified SSL certificate error. We now look for the fingerprint using a regex. We don't care where it is in the string, so long as it's there somewhere. Both that and the P4PORT get passed into the `Certificate` used for the error message, which will then be displayed to the user.

0bc2406a91fcab899eac76f52211f21be81e7be0

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Updated the fingerprint scanning (hah) to not crash if the fingerprint couldn't be found.

Commits:

	Summary	ID
	Improve Perforce SSL fingerprint parsing and error reporting. The Perforce SSL error handling assumed some things about the placement of the fingerprint in the error message. This wasn't always correct, though. While this hasn't really been an issue in the past, practically speaking, it is now that we have improved unverified SSL certificate error. We now look for the fingerprint using a regex. We don't care where it is in the string, so long as it's there somewhere. Both that and the P4PORT get passed into the `Certificate` used for the error message, which will then be displayed to the user.	00303f3dde1f326600e88c0616050844758fcf93
	Improve Perforce SSL fingerprint parsing and error reporting. The Perforce SSL error handling assumed some things about the placement of the fingerprint in the error message. This wasn't always correct, though. While this hasn't really been an issue in the past, practically speaking, it is now that we have improved unverified SSL certificate error. We now look for the fingerprint using a regex. We don't care where it is in the string, so long as it's there somewhere. Both that and the P4PORT get passed into the `Certificate` used for the error message, which will then be displayed to the user.	0bc2406a91fcab899eac76f52211f21be81e7be0

Diff:

Revision 2 (+254 -8)

Show changes

	reviewboard/scmtools/perforce.py
	reviewboard/scmtools/tests/test_perforce.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (e254dc3)