Improve the error message when encountering an unverified certificate.

Review Request #11125 — Created Aug. 6, 2020 and submitted

chipx86
Review Board
release-3.0.x
reviewboard

The error message saying that repository communication encountered an
unverified certificate didn't really do enough to help diagnose the
problem. All the user was left with was an idea that something went
wrong, but not really what that was.

This expands on it a bit, placing additional information within the
error message to identify the hostname and the fingerprint, so users can
confirm whether they match expectations.

Tested along with an upcoming change to Perforce. Verified the error
response when encountering an unverified SSL certificate.

Configured a Perforce repository with a self-signed SSL certificate
and checked the prompt to make sure it was using the repository form's
standard text.

Summary
Improve the error message when encountering an unverified certificate.
Description From Last Updated

pertain -> pertains

daviddavid

Same here.

daviddavid
david
  1. 
      
  2. reviewboard/scmtools/errors.py (Diff revision 1)
     
     

    pertain -> pertains

  3. reviewboard/scmtools/errors.py (Diff revision 1)
     
     

    Same here.

  4. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (fe5fae7)
Loading...