Summary

Improve the error message when encountering an unverified certificate.

Review Request #11125 — Created Aug. 6, 2020 and submitted Aug. 7, 2020, 10:29 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This expands on it a bit, placing additional information within the
error message to identify the hostname and the fingerprint, so users can
confirm whether they match expectations.

Testing Done

Tested along with an upcoming change to Perforce. Verified the error
response when encountering an unverified SSL certificate.

Configured a Perforce repository with a self-signed SSL certificate
and checked the prompt to make sure it was using the repository form's
standard text.

Commits

Summary	ID
Improve the error message when encountering an unverified certificate. The error message saying that repository communication encountered an unverified certificate didn't really do enough to help diagnose the problem. All the user was left with was an idea that something went wrong, but not really what that was. This expands on it a bit, placing additional information within the error message to identify the hostname and the fingerprint, so users can confirm whether they match expectations.	5cbe663082c9a9b01046e3eee8ab9ca7140d14a7

Summary

Improve the error message when encountering an unverified certificate.

The error message saying that repository communication encountered an unverified certificate didn't really do enough to help diagnose the problem. All the user was left with was an idea that something went wrong, but not really what that was. This expands on it a bit, placing additional information within the error message to identify the hostname and the fingerprint, so users can confirm whether they match expectations.

5cbe663082c9a9b01046e3eee8ab9ca7140d14a7

Issues

Description	From	Last Updated
pertain -> pertains	david	Aug. 7, 2020, 3:51 p.m.
Same here.	david	Aug. 7, 2020, 3:51 p.m.

flake8 passed.

JSHint passed.

reviewboard/scmtools/errors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
pertain -> pertains
```
reviewboard/scmtools/errors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```

Change Summary:

Fixed a typo in docstrings.

Commits:

	Summary	ID
	Improve the error message when encountering an unverified certificate. The error message saying that repository communication encountered an unverified certificate didn't really do enough to help diagnose the problem. All the user was left with was an idea that something went wrong, but not really what that was. This expands on it a bit, placing additional information within the error message to identify the hostname and the fingerprint, so users can confirm whether they match expectations.	437faaa008b821117e32d1e4b59b632c44db121d
	Improve the error message when encountering an unverified certificate. The error message saying that repository communication encountered an unverified certificate didn't really do enough to help diagnose the problem. All the user was left with was an idea that something went wrong, but not really what that was. This expands on it a bit, placing additional information within the error message to identify the hostname and the fingerprint, so users can confirm whether they match expectations.	5cbe663082c9a9b01046e3eee8ab9ca7140d14a7

Diff:

Revision 2 (+70 -6)

Show changes

reviewboard/scmtools/errors.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (fe5fae7)