Summary

Fix regressions with the Django 2.0 unique index quoting patch.

Review Request #11105 — Created July 30, 2020 and submitted Aug. 4, 2020, 5:17 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

The new compatibility patch for Django 2.0 that quotes unique index

names didn't cover all the input cases. If either a None was generated

for the index name, or an explicit string was provided, it would assert.

Both of these cases are valid with the function the patch is overriding.
We now just check for these cases and only quote if all our criteria is

met.

Testing Done

Verified that these conditions no longer crash on Django 2.0. (These are
triggered with some upcoming changes.)

Commits

Summary	ID
Fix regressions with the Django 2.0 unique index quoting patch. The new compatibility patch for Django 2.0 that quotes unique index names didn't cover all the input cases. If either a `None` was generated for the index name, or an explicit string was provided, it would assert. Both of these cases are valid with the function the patch is overriding. We now just check for these cases and only quote if all our criteria is met.	e223c01de612e648286e419abcb3f91dc89e1684

Summary

Fix regressions with the Django 2.0 unique index quoting patch.

The new compatibility patch for Django 2.0 that quotes unique index names didn't cover all the input cases. If either a `None` was generated for the index name, or an explicit string was provided, it would assert. Both of these cases are valid with the function the patch is overriding. We now just check for these cases and only quote if all our criteria is met.

e223c01de612e648286e419abcb3f91dc89e1684

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (4e65c22)