[shipit-ascii-art] Modernize the ASCII Art extension.
Review Request #11088 — Created July 20, 2020 and submitted — Latest diff uploaded
This change modernizes the Ship It! ASCII Art extension and dramatically
simplifies the codebase by consolidating everything into the extension
file, while deleting unused code. Most notably, it switches to using
SignalHook to connect the signal handler, which will behave correctly
when deactivating the extension.
Activated the extension and verified the results.
Diff Revision 1 (Latest)
Commits
Files
| shipit_ascii_art/shipit_ascii_art/admin_urls.py |
|---|
| shipit_ascii_art/shipit_ascii_art/asciiart.py |
|---|
| shipit_ascii_art/shipit_ascii_art/extension.py |
|---|
| shipit_ascii_art/shipit_ascii_art/handlers.py |
|---|
| shipit_ascii_art/shipit_ascii_art/views.py |
|---|
| shipit_ascii_art/shipit_ascii_art/templates/shipit_ascii_art/configure.html |
|---|
| shipit_ascii_art/shipit_ascii_art/templates/shipit_ascii_art/dashboard.html |
|---|