Summary

[shipit-ascii-art] Modernize the ASCII Art extension.

Review Request #11088 — Created July 20, 2020 and submitted July 21, 2020, 9:50 a.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

This change modernizes the Ship It! ASCII Art extension and dramatically
simplifies the codebase by consolidating everything into the extension
file, while deleting unused code. Most notably, it switches to using
SignalHook to connect the signal handler, which will behave correctly
when deactivating the extension.

Testing Done

Activated the extension and verified the results.

Commits

Summary	ID
[shipit-ascii-art] Modernize the ASCII Art extension. This change modernizes the Ship It! ASCII Art extension and dramatically simplifies the codebase by consolidating everything into the extension file, while deleting unused code. Most notably, it switches to using SignalHook to connect the signal handler, which will behave correctly when deactivating the extension. Testing Done: Activated the extension and verified the results.	04f4ee074057816125ee731c72d8f7d725d575f6

Summary

[shipit-ascii-art] Modernize the ASCII Art extension.

This change modernizes the Ship It! ASCII Art extension and dramatically simplifies the codebase by consolidating everything into the extension file, while deleting unused code. Most notably, it switches to using SignalHook to connect the signal handler, which will behave correctly when deactivating the extension. Testing Done: Activated the extension and verified the results.

04f4ee074057816125ee731c72d8f7d725d575f6

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (f24d47a)