[review-together] Modernize the review-together codebase.

Review Request #11087 — Created July 20, 2020 and submitted

Information

rb-extension-pack
master

Reviewers

This change updates the review-together extension, porting the JS side
to ES6, updating the Python code for Django 1.11/Python 3/Review Board
4.0 compatibility, and converting the CSS to use our new color
definitions.

The visual appearance isn't super polished (many of the colors are a
little bit clashy with TogetherJS's icons), but I haven't changed
anything there. Updating to the latest TogetherJS and polishing the UI
might make for a good student project at some point.

Installed and activated the extension. Verified that the settings form
and frontend UI worked as expected.

Summary ID
[review-together] Modernize the review-together codebase.
This change updates the review-together extension, porting the JS side to ES6, updating the Python code for Django 1.11/Python 3/Review Board 4.0 compatibility, and converting the CSS to use our new color definitions. The visual appearance isn't super polished (many of the colors are a little bit clashy with TogetherJS's icons), but I haven't changed anything there. Updating to the latest TogetherJS and polishing the UI might make for a good student project at some point. Testing Done: Installed and activated the extension. Verified that the settings form and frontend UI worked as expected. Reviewed at https://reviews.reviewboard.org/r/11087/
a172453f949c922f1c3ec250b8d92c76b2ab4c6d
Description From Last Updated

Minor thing, but while updating the code, we should probably just add docs for this.

chipx86chipx86

Col: 17 Missing 'new' prefix when invoking a constructor.

reviewbotreviewbot

Col: 17 Missing 'new' prefix when invoking a constructor.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
  1. 
      
  2. Show all issues

    Minor thing, but while updating the code, we should probably just add docs for this.

  3. 
      
david
Review request changed
Commits:
Summary ID
[review-together] Modernize the review-together codebase.
This change updates the review-together extension, porting the JS side to ES6, updating the Python code for Django 1.11/Python 3/Review Board 4.0 compatibility, and converting the CSS to use our new color definitions. The visual appearance isn't super polished (many of the colors are a little bit clashy with TogetherJS's icons), but I haven't changed anything there. Updating to the latest TogetherJS and polishing the UI might make for a good student project at some point. Testing Done: Installed and activated the extension. Verified that the settings form and frontend UI worked as expected.
e74b51bd36c7c4de11268b93a387c5777c8ab141
[review-together] Modernize the review-together codebase.
This change updates the review-together extension, porting the JS side to ES6, updating the Python code for Django 1.11/Python 3/Review Board 4.0 compatibility, and converting the CSS to use our new color definitions. The visual appearance isn't super polished (many of the colors are a little bit clashy with TogetherJS's icons), but I haven't changed anything there. Updating to the latest TogetherJS and polishing the UI might make for a good student project at some point. Testing Done: Installed and activated the extension. Verified that the settings form and frontend UI worked as expected. Reviewed at https://reviews.reviewboard.org/r/11087/
a172453f949c922f1c3ec250b8d92c76b2ab4c6d

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (359d6d2)