Summary

[review-together] Modernize the review-together codebase.

Review Request #11087 — Created July 20, 2020 and submitted July 28, 2020, 4:18 p.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

The visual appearance isn't super polished (many of the colors are a
little bit clashy with TogetherJS's icons), but I haven't changed
anything there. Updating to the latest TogetherJS and polishing the UI
might make for a good student project at some point.

Testing Done

Installed and activated the extension. Verified that the settings form
and frontend UI worked as expected.

Commits

Summary	ID
[review-together] Modernize the review-together codebase. This change updates the review-together extension, porting the JS side to ES6, updating the Python code for Django 1.11/Python 3/Review Board 4.0 compatibility, and converting the CSS to use our new color definitions. The visual appearance isn't super polished (many of the colors are a little bit clashy with TogetherJS's icons), but I haven't changed anything there. Updating to the latest TogetherJS and polishing the UI might make for a good student project at some point. Testing Done: Installed and activated the extension. Verified that the settings form and frontend UI worked as expected. Reviewed at https://reviews.reviewboard.org/r/11087/	a172453f949c922f1c3ec250b8d92c76b2ab4c6d

Summary

[review-together] Modernize the review-together codebase.

This change updates the review-together extension, porting the JS side to ES6, updating the Python code for Django 1.11/Python 3/Review Board 4.0 compatibility, and converting the CSS to use our new color definitions. The visual appearance isn't super polished (many of the colors are a little bit clashy with TogetherJS's icons), but I haven't changed anything there. Updating to the latest TogetherJS and polishing the UI might make for a good student project at some point. Testing Done: Installed and activated the extension. Verified that the settings form and frontend UI worked as expected. Reviewed at https://reviews.reviewboard.org/r/11087/

a172453f949c922f1c3ec250b8d92c76b2ab4c6d

Issues

Description	From	Last Updated
Minor thing, but while updating the code, we should probably just add docs for this.	chipx86	July 21, 2020, 9:44 a.m.
Col: 17 Missing 'new' prefix when invoking a constructor.	reviewbot	July 20, 2020, 1:04 p.m.
Col: 17 Missing 'new' prefix when invoking a constructor.	reviewbot	July 21, 2020, 9:47 a.m.

flake8 passed.

JSHint failed.

JSHint

review_together/review_together/static/js/reviewTogether.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 17
 Missing 'new' prefix when invoking a constructor.
```

review_together/review_together/static/js/reviewTogether.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Minor thing, but while updating the code, we should probably just add docs for this.
```

Commits:

	Summary	ID
	[review-together] Modernize the review-together codebase. This change updates the review-together extension, porting the JS side to ES6, updating the Python code for Django 1.11/Python 3/Review Board 4.0 compatibility, and converting the CSS to use our new color definitions. The visual appearance isn't super polished (many of the colors are a little bit clashy with TogetherJS's icons), but I haven't changed anything there. Updating to the latest TogetherJS and polishing the UI might make for a good student project at some point. Testing Done: Installed and activated the extension. Verified that the settings form and frontend UI worked as expected.	e74b51bd36c7c4de11268b93a387c5777c8ab141
	[review-together] Modernize the review-together codebase. This change updates the review-together extension, porting the JS side to ES6, updating the Python code for Django 1.11/Python 3/Review Board 4.0 compatibility, and converting the CSS to use our new color definitions. The visual appearance isn't super polished (many of the colors are a little bit clashy with TogetherJS's icons), but I haven't changed anything there. Updating to the latest TogetherJS and polishing the UI might make for a good student project at some point. Testing Done: Installed and activated the extension. Verified that the settings form and frontend UI worked as expected. Reviewed at https://reviews.reviewboard.org/r/11087/	a172453f949c922f1c3ec250b8d92c76b2ab4c6d

Diff:

Revision 2 (+300 -282)

Show changes

	review_together/review_together/admin_urls.py
	review_together/review_together/extension.py
	review_together/review_together/forms.py
	review_together/review_together/static/css/review-together.less
	review_together/review_together/static/js/review-together.js
	review_together/review_together/static/js/reviewTogether.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

review_together/review_together/static/js/reviewTogether.es6.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 17
 Missing 'new' prefix when invoking a constructor.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (359d6d2)