Add a compatibility patch for Django 2.0's SQLite unique index name quoting.

Review Request #11085 — Created July 17, 2020 and submitted

Information

Django Evolution
master

Reviewers

Django 2.0 had a bug when generating SQL for creating a unique index
where the name wasn't being quoted. This could result in statements with
syntax errors, and impacted some unit tests.

This change adds a runtime compatibility patch that overrides Django
2.0's _create_unique_sql() that adds quoting, if code is detected that
would skip the quoting.

This won't impact any version of Django that has the correct quoting
behavior.

Unit tests pass on Django 2.0.

Summary ID
Add a compatibility patch for Django 2.0's SQLite unique index name quoting.
Django 2.0 had a bug when generating SQL for creating a unique index where the name wasn't being quoted. This could result in statements with syntax errors, and impacted some unit tests. This change adds a runtime compatibility patch that overrides Django 2.0's `_create_unique_sql()` that adds quoting, if code is detected that would skip the quoting. This won't impact any version of Django that has the correct quoting behavior.
8f5b9a85ef2a40cc9459bebe1d31f41f17252a2c
david
  1. Ship It!
  2. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (e4c02d3)