Summary

Add a compatibility patch for Django 2.0's SQLite unique index name quoting.

Review Request #11085 — Created July 17, 2020 and submitted July 28, 2020, 7:16 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

Django 2.0 had a bug when generating SQL for creating a unique index
where the name wasn't being quoted. This could result in statements with
syntax errors, and impacted some unit tests.

This change adds a runtime compatibility patch that overrides Django
2.0's _create_unique_sql() that adds quoting, if code is detected that
would skip the quoting.

This won't impact any version of Django that has the correct quoting
behavior.

Testing Done

Unit tests pass on Django 2.0.

Commits

Summary	ID
Add a compatibility patch for Django 2.0's SQLite unique index name quoting. Django 2.0 had a bug when generating SQL for creating a unique index where the name wasn't being quoted. This could result in statements with syntax errors, and impacted some unit tests. This change adds a runtime compatibility patch that overrides Django 2.0's `_create_unique_sql()` that adds quoting, if code is detected that would skip the quoting. This won't impact any version of Django that has the correct quoting behavior.	8f5b9a85ef2a40cc9459bebe1d31f41f17252a2c

Summary

Add a compatibility patch for Django 2.0's SQLite unique index name quoting.

Django 2.0 had a bug when generating SQL for creating a unique index where the name wasn't being quoted. This could result in statements with syntax errors, and impacted some unit tests. This change adds a runtime compatibility patch that overrides Django 2.0's `_create_unique_sql()` that adds quoting, if code is detected that would skip the quoting. This won't impact any version of Django that has the correct quoting behavior.

8f5b9a85ef2a40cc9459bebe1d31f41f17252a2c

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Improved the check to avoid an issue that could come up on Django 1.11.

Commits:

	Summary	ID
	Add a compatibility patch for Django 2.0's SQLite unique index name quoting. Django 2.0 had a bug when generating SQL for creating a unique index where the name wasn't being quoted. This could result in statements with syntax errors, and impacted some unit tests. This change adds a runtime compatibility patch that overrides Django 2.0's `_create_unique_sql()` that adds quoting, if code is detected that would skip the quoting. This won't impact any version of Django that has the correct quoting behavior.	ea6d0b25343e15f862ec43702afda30cfcb712af
	Add a compatibility patch for Django 2.0's SQLite unique index name quoting. Django 2.0 had a bug when generating SQL for creating a unique index where the name wasn't being quoted. This could result in statements with syntax errors, and impacted some unit tests. This change adds a runtime compatibility patch that overrides Django 2.0's `_create_unique_sql()` that adds quoting, if code is detected that would skip the quoting. This won't impact any version of Django that has the correct quoting behavior.	8f5b9a85ef2a40cc9459bebe1d31f41f17252a2c

Diff:

Revision 2 (+116 -2)

Show changes

	django_evolution/compat/patches/__init__.py
	django_evolution/compat/patches/django2_0_quote_unique_index_name.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (e4c02d3)