[rbxmlreview] Modernize the XML Review extension.

Review Request #11081 — Created July 15, 2020 and submitted — Latest diff uploaded

Information

rb-extension-pack
master

Reviewers

The XML review UI extension was pretty long in the tooth, and wasn't
using static media or the review UI JavaScript infrastructure in the
correct way. This change updates it so that it doesn't need its own
template, and relies on static media bundles instead of manually loading
the JavaScript file.

Enabled the extension. Uploaded an XML file and was able to review it.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.

orig
1
2
3
4

Commits

First Last Summary ID Author
[rbxmlreview] Modernize the XML Review extension.
The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.
75450735f403f1413651eaf4aeca31528fcb0ef3 David Trowbridge
rbxmlreview/rbxmlreview/admin_urls.py
rbxmlreview/rbxmlreview/extension.py
rbxmlreview/rbxmlreview/rbxmlreview.py
rbxmlreview/rbxmlreview/reviewui.py
rbxmlreview/rbxmlreview/static/js/xmlReviewableModel.es6.js
rbxmlreview/rbxmlreview/htdocs/js/xmlReviewableView.js
rbxmlreview/rbxmlreview/templates/rbxmlreview/xml.html
Loading...