[rbxmlreview] Modernize the XML Review extension.

Review Request #11081 — Created July 15, 2020 and submitted

david
rb-extension-pack
master
rb-extension-pack

The XML review UI extension was pretty long in the tooth, and wasn't
using static media or the review UI JavaScript infrastructure in the
correct way. This change updates it so that it doesn't need its own
template, and relies on static media bundles instead of manually loading
the JavaScript file.

Enabled the extension. Uploaded an XML file and was able to review it.

Summary
[rbxmlreview] Modernize the XML Review extension.
Description From Last Updated

"Testing Done" didn't make it into the right field.

chipx86chipx86

E999 SyntaxError: invalid syntax

reviewbotreviewbot

Bare imports go before from ... imports.

chipx86chipx86

You can just access XMLReviewUIExtension.instance.

chipx86chipx86

F401 'rbxmlreview.extension.XMLReviewUIExtenison' imported but unused

reviewbotreviewbot

F821 undefined name 'XMLReviewUIExtension'

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
chipx86
  1. 
      
  2. "Testing Done" didn't make it into the right field.

  3. rbxmlreview/rbxmlreview/reviewui.py (Diff revision 2)
     
     
     
     
     
     

    Bare imports go before from ... imports.

  4. rbxmlreview/rbxmlreview/reviewui.py (Diff revision 2)
     
     
     

    You can just access XMLReviewUIExtension.instance.

  5. 
      
david
Review request changed

Description:

   

The XML review UI extension was pretty long in the tooth, and wasn't

    using static media or the review UI JavaScript infrastructure in the
    correct way. This change updates it so that it doesn't need its own
    template, and relies on static media bundles instead of manually loading
    the JavaScript file.

-  
-  

Testing Done:

-   Enabled the extension. Uploaded an XML file and was able to review it.

Testing Done:

  +

Enabled the extension. Uploaded an XML file and was able to review it.

Commits:

Summary
-
[rbxmlreview] Modernize the XML Review extension.
+
[rbxmlreview] Modernize the XML Review extension.

Diff:

Revision 3 (+236 -150)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (5a5705b)
Loading...