Summary

[rbxmlreview] Modernize the XML Review extension.

Review Request #11081 — Created July 15, 2020 and submitted July 21, 2020, 9:48 a.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

The XML review UI extension was pretty long in the tooth, and wasn't

using static media or the review UI JavaScript infrastructure in the

correct way. This change updates it so that it doesn't need its own

template, and relies on static media bundles instead of manually loading

the JavaScript file.

Testing Done

Enabled the extension. Uploaded an XML file and was able to review it.

Commits

Summary	ID
[rbxmlreview] Modernize the XML Review extension. The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.	35ccc0f28f6ae38905e9f5c07a0e93b2cfb10744

Summary

[rbxmlreview] Modernize the XML Review extension.

The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.

35ccc0f28f6ae38905e9f5c07a0e93b2cfb10744

Issues

Description	From	Last Updated
"Testing Done" didn't make it into the right field.	chipx86	July 20, 2020, 1:05 p.m.
E999 SyntaxError: invalid syntax	reviewbot	July 15, 2020, 12:20 p.m.
Bare imports go before from ... imports.	chipx86	July 20, 2020, 1:05 p.m.
You can just access XMLReviewUIExtension.instance.	chipx86	July 20, 2020, 1:06 p.m.
F401 'rbxmlreview.extension.XMLReviewUIExtenison' imported but unused	reviewbot	July 20, 2020, 4:23 p.m.
F821 undefined name 'XMLReviewUIExtension'	reviewbot	July 20, 2020, 4:23 p.m.

flake8 failed.

JSHint passed.

flake8

rbxmlreview/rbxmlreview/reviewui.py (Diff revision 1)
Show all issues
```
E999 SyntaxError: invalid syntax
```

Change Summary:

Half committed.

Commits:

	Summary	ID
	[rbxmlreview] Modernize the XML Review extension. The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.	75450735f403f1413651eaf4aeca31528fcb0ef3
	[rbxmlreview] Modernize the XML Review extension. The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.	80cbe87c06c8d8ee333ccf0de267e6caac7c0065

Diff:

Revision 2 (+206 -148)

Show changes

	rbxmlreview/rbxmlreview/admin_urls.py
	rbxmlreview/rbxmlreview/extension.py
	rbxmlreview/rbxmlreview/rbxmlreview.py
	rbxmlreview/rbxmlreview/reviewui.py
	rbxmlreview/rbxmlreview/static/js/xmlReviewableModel.es6.js
	rbxmlreview/rbxmlreview/htdocs/js/xmlReviewableView.js
	rbxmlreview/rbxmlreview/templates/rbxmlreview/xml.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues

"Testing Done" didn't make it into the right field.

rbxmlreview/rbxmlreview/reviewui.py (Diff revision 2)

Show all issues

Bare imports go before from ... imports.

rbxmlreview/rbxmlreview/reviewui.py (Diff revision 2)
Show all issues
```
You can just access XMLReviewUIExtension.instance.
```

Description:

		The XML review UI extension was pretty long in the tooth, and wasn't
		using static media or the review UI JavaScript infrastructure in the
		correct way. This change updates it so that it doesn't need its own
		template, and relies on static media bundles instead of manually loading
		the JavaScript file.
-
-		Testing Done:
-		Enabled the extension. Uploaded an XML file and was able to review it.

Testing Done:

Enabled the extension. Uploaded an XML file and was able to review it.

Commits:

	Summary	ID
	[rbxmlreview] Modernize the XML Review extension. The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.	80cbe87c06c8d8ee333ccf0de267e6caac7c0065
	[rbxmlreview] Modernize the XML Review extension. The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.	66aabb45e617f21e2ce5ba789b3a8f1bf607be0d

Diff:

Revision 3 (+236 -150)

Show changes

	rbxmlreview/rbxmlreview/admin_urls.py
	rbxmlreview/rbxmlreview/extension.py
	rbxmlreview/rbxmlreview/mimetypes.py
	rbxmlreview/rbxmlreview/rbxmlreview.py
	rbxmlreview/rbxmlreview/reviewui.py
	rbxmlreview/rbxmlreview/static/js/xmlReviewableModel.es6.js
	rbxmlreview/rbxmlreview/htdocs/js/xmlReviewableView.js
	rbxmlreview/rbxmlreview/templates/rbxmlreview/xml.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbxmlreview/rbxmlreview/reviewui.py (Diff revision 3)

Show all issues

F401 'rbxmlreview.extension.XMLReviewUIExtenison' imported but unused

rbxmlreview/rbxmlreview/reviewui.py (Diff revision 3)
Show all issues
```
F821 undefined name 'XMLReviewUIExtension'
```

Change Summary:

Typo.

Commits:

	Summary	ID
	[rbxmlreview] Modernize the XML Review extension. The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.	66aabb45e617f21e2ce5ba789b3a8f1bf607be0d
	[rbxmlreview] Modernize the XML Review extension. The XML review UI extension was pretty long in the tooth, and wasn't using static media or the review UI JavaScript infrastructure in the correct way. This change updates it so that it doesn't need its own template, and relies on static media bundles instead of manually loading the JavaScript file. Testing Done: Enabled the extension. Uploaded an XML file and was able to review it.	35ccc0f28f6ae38905e9f5c07a0e93b2cfb10744

Diff:

Revision 4 (+236 -150)

Show changes

	rbxmlreview/rbxmlreview/admin_urls.py
	rbxmlreview/rbxmlreview/extension.py
	rbxmlreview/rbxmlreview/mimetypes.py
	rbxmlreview/rbxmlreview/rbxmlreview.py
	rbxmlreview/rbxmlreview/reviewui.py
	rbxmlreview/rbxmlreview/static/js/xmlReviewableModel.es6.js
	rbxmlreview/rbxmlreview/htdocs/js/xmlReviewableView.js
	rbxmlreview/rbxmlreview/templates/rbxmlreview/xml.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (5a5705b)