[rbstopwtach] Modernize the stopwatch extension.

Review Request #11079 — Created July 13, 2020 and submitted

Information

rb-extension-pack
master

Reviewers

This change modernizes the codebase for the stopwatch extension,
primarily porting the JavaScript side over to ES6.

Enabled the extension and timed a review.

Summary ID
[rbstopwtach] Modernize the stopwatch extension.
This change modernizes the codebase for the stopwatch extension, primarily porting the JavaScript side over to ES6. Testing Done: Enabled the extension and timed a review.
99613ff40461bd967991a551d948320b1385ca3b
Description From Last Updated

Col: 15 'reviewDialogHook' is defined but never used.

reviewbotreviewbot

Missing a "Returns".

chipx86chipx86

These should be <%- to escape contents.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
chipx86
  1. 
      
  2. rbstopwatch/rbstopwatch/static/js/stopwatch.es6.js (Diff revision 2)
     
     
     
     
     
     
     
     
     

    Missing a "Returns".

  3. These should be <%- to escape contents.

  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (b3b1607)
Loading...