Summary

[rbstopwtach] Modernize the stopwatch extension.

Review Request #11079 — Created July 13, 2020 and submitted July 21, 2020, 9:47 a.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

This change modernizes the codebase for the stopwatch extension,
primarily porting the JavaScript side over to ES6.

Testing Done

Enabled the extension and timed a review.

Commits

Summary	ID
[rbstopwtach] Modernize the stopwatch extension. This change modernizes the codebase for the stopwatch extension, primarily porting the JavaScript side over to ES6. Testing Done: Enabled the extension and timed a review.	99613ff40461bd967991a551d948320b1385ca3b

Issues

Description	From	Last Updated
Col: 15 'reviewDialogHook' is defined but never used.	reviewbot	July 13, 2020, 2:27 p.m.
Missing a "Returns".	chipx86	July 20, 2020, 1:03 p.m.
These should be <%- to escape contents.	chipx86	July 20, 2020, 1:04 p.m.

flake8 passed.

JSHint failed.

JSHint

rbstopwatch/rbstopwatch/static/js/stopwatch.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 15
 'reviewDialogHook' is defined but never used.
```

Commits:

	Summary	ID
	[rbstopwtach] Modernize the stopwatch extension. This change modernizes the codebase for the stopwatch extension, primarily porting the JavaScript side over to ES6. Testing Done: Enabled the extension and timed a review.	2f0a3ec4a314661e87b74cd0b22fe48abfc645d3
	[rbstopwtach] Modernize the stopwatch extension. This change modernizes the codebase for the stopwatch extension, primarily porting the JavaScript side over to ES6. Testing Done: Enabled the extension and timed a review.	7b4384112f467351b2dfae76b5035f94818b7cdd

Diff:

Revision 2 (+254 -204)

Show changes

	rbstopwatch/rbstopwatch/__init__.py
	rbstopwatch/rbstopwatch/extension.py
	rbstopwatch/rbstopwatch/static/js/stopwatch.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbstopwatch/rbstopwatch/static/js/stopwatch.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

Missing a "Returns".

rbstopwatch/rbstopwatch/static/js/stopwatch.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
These should be <%- to escape contents.
```

Commits:

	Summary	ID
	[rbstopwtach] Modernize the stopwatch extension. This change modernizes the codebase for the stopwatch extension, primarily porting the JavaScript side over to ES6. Testing Done: Enabled the extension and timed a review.	7b4384112f467351b2dfae76b5035f94818b7cdd
	[rbstopwtach] Modernize the stopwatch extension. This change modernizes the codebase for the stopwatch extension, primarily porting the JavaScript side over to ES6. Testing Done: Enabled the extension and timed a review.	99613ff40461bd967991a551d948320b1385ca3b

Diff:

Revision 3 (+262 -204)

Show changes

	rbstopwatch/rbstopwatch/__init__.py
	rbstopwatch/rbstopwatch/extension.py
	rbstopwatch/rbstopwatch/static/js/stopwatch.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (b3b1607)