Update the Storage Settings page for modern subform support.

Review Request #11065 — Created July 3, 2020 and submitted

Information

Review Board
release-4.0.x

Reviewers

The Storage Settings page has been updated to work with the subform
support introduced in Review Board 4.0. This gives us a maintainable way
of allowing authentication forms to be added to the page and configured
without triggering any browser-side validation issues for unselected
subforms.

In order for this to work, the existing settings form had to be split up
into subforms. Ideally, we'd have pluggable backends we'd load settings
forms from, but this is at least a step toward that.

Tested saving the search form with each storage backend subform selection.
Verified that only the selected subforms received any client-side or
server-side validation, and that settings loaded and saved.

Summary ID
Update the Storage Settings page for modern subform support.
The Storage Settings page has been updated to work with the subform support introduced in Review Board 4.0. This gives us a maintainable way of allowing authentication forms to be added to the page and configured without triggering any browser-side validation issues for unselected subforms. In order for this to work, the existing settings form had to be split up into subforms. Ideally, we'd have pluggable backends we'd load settings forms from, but this is at least a step toward that.
73c0dd07a39e124881d45e6a350874ef09023ccf
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (ef5c50e)
Loading...