Modernize rbwebhooks for Review Board 4.0.

Review Request #11062 — Created July 2, 2020 and submitted

Information

rb-extension-pack
master

Reviewers

This change updates the rbwebhooks extension for Review Board 4.0/Django
1.11. It also updates the code to use six moves for urllib, and adds
docstrings.

Activated the extension and played with the settings.

Summary ID
Modernize rbwebhooks for Review Board 4.0.
This change updates the rbwebhooks extension for Review Board 4.0/Django 1.11. It also updates the code to use six moves for urllib, and adds docstrings. Testing Done: Activated the extension and played with the settings.
192c8af91d8b96e1b2da9604965738a8ee5d68d6
Description From Last Updated

F821 undefined name 'payload'

reviewbotreviewbot

F841 local variable 'attemps' is assigned to but never used

reviewbotreviewbot

F821 undefined name 'attempts'

reviewbotreviewbot

These should be in alphabetical order.

chipx86chipx86

While here, can you correct the type on "bennificial"?

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
Review request changed
Change Summary:

Actually commit my half-baked work.

Commits:
Summary ID
Modernize rbwebhooks for Review Board 4.0.
This change updates the rbwebhooks extension for Review Board 4.0/Django 1.11. It also updates the code to use six moves for urllib, and adds docstrings. Testing Done: Activated the extension and played with the settings.
4155f1ddc394a5424efd35ce8c675f2cf35b30f2
Modernize rbwebhooks for Review Board 4.0.
This change updates the rbwebhooks extension for Review Board 4.0/Django 1.11. It also updates the code to use six moves for urllib, and adds docstrings. Testing Done: Activated the extension and played with the settings.
3e9e7a66d32d19c41347c3510ee704be21b7a853

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
chipx86
  1. 
      
  2. rbwebhooks/rbwebhooks/extension.py (Diff revision 3)
     
     
     
     
    Show all issues

    These should be in alphabetical order.

  3. rbwebhooks/rbwebhooks/extension.py (Diff revision 3)
     
     
    Show all issues

    While here, can you correct the type on "bennificial"?

  4. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (9571132)