flake8
failed.
JSHint
passed.
flake8
-
rbwebhooks/rbwebhooks/extension.py (Diff revision 1) Show all issues
Modernize rbwebhooks for Review Board 4.0.
Review Request #11062 — Created July 2, 2020 and submitted
| Information | |
|---|---|
| david | |
| rb-extension-pack | |
| master | |
| Reviewers | |
| rb-extension-pack | |
This change updates the rbwebhooks extension for Review Board 4.0/Django
1.11. It also updates the code to use six moves for urllib, and adds
docstrings.
Activated the extension and played with the settings.
Change Summary:
Actually commit my half-baked work.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+226 -110) |
|||||||||
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
rbwebhooks/rbwebhooks/extension.py (Diff revision 2) F841 local variable 'attemps' is assigned to but never used
-
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+226 -110) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
rbwebhooks/rbwebhooks/extension.py (Diff revision 3) While here, can you correct the type on "bennificial"?