Modernize rbwebhooks for Review Board 4.0.

Review Request #11062 — Created July 2, 2020 and submitted

Information
david
rb-extension-pack
master
Reviewers
rb-extension-pack 
This change updates the rbwebhooks extension for Review Board 4.0/Django

1.11. It also updates the code to use six moves for urllib, and adds

docstrings.
Activated the extension and played with the settings.
Summary 
Modernize rbwebhooks for Review Board 4.0.
Description From Last Updated

F821 undefined name 'payload'

 reviewbotreviewbot

F841 local variable 'attemps' is assigned to but never used

 reviewbotreviewbot

F821 undefined name 'attempts'

 reviewbotreviewbot

These should be in alphabetical order.

 chipx86chipx86

While here, can you correct the type on "bennificial"?

 chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
Review request changed

Change Summary:

Actually commit my half-baked work.

Commits:
Summary
- 
Modernize rbwebhooks for Review Board 4.0.
+ 
Modernize rbwebhooks for Review Board 4.0.

Diff:

Revision 2 (+226 -110)

Show changes

rbwebhooks/rbwebhooks/admin.py
rbwebhooks/rbwebhooks/admin_urls.py
rbwebhooks/rbwebhooks/extension.py
rbwebhooks/rbwebhooks/forms.py
rbwebhooks/rbwebhooks/handlers.py
rbwebhooks/rbwebhooks/models.py

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
chipx86
chipx86 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      rbwebhooks/rbwebhooks/extension.py
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    These should be in alphabetical order.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      rbwebhooks/rbwebhooks/extension.py
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    While here, can you correct the type on "bennificial"?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (9571132)





 


 










  

 









     

    

   

  

  

   
   Loading...