This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (9571132)

Summary

Modernize rbwebhooks for Review Board 4.0.

Review Request #11062 — Created July 2, 2020 and submitted 4 years, 11 months ago

Information

Owner

david*

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description*

This change updates the rbwebhooks extension for Review Board 4.0/Django
1.11. It also updates the code to use six moves for urllib, and adds
docstrings.

Testing Done

Activated the extension and played with the settings.

Commits

Summary	ID
Modernize rbwebhooks for Review Board 4.0. This change updates the rbwebhooks extension for Review Board 4.0/Django 1.11. It also updates the code to use six moves for urllib, and adds docstrings. Testing Done: Activated the extension and played with the settings.	192c8af91d8b96e1b2da9604965738a8ee5d68d6

Issues

Description	From	Last Updated
F821 undefined name 'payload'	reviewbot	4 years, 11 months ago
F841 local variable 'attemps' is assigned to but never used	reviewbot	4 years, 11 months ago
F821 undefined name 'attempts'	reviewbot	4 years, 11 months ago
These should be in alphabetical order.	chipx86	4 years, 11 months ago
While here, can you correct the type on "bennificial"?	chipx86	4 years, 11 months ago
There are no open issues

flake8 failed.

JSHint passed.

flake8

rbwebhooks/rbwebhooks/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'payload'
```

Change Summary:

Actually commit my half-baked work.

Commits:

	Summary	ID
	Modernize rbwebhooks for Review Board 4.0. This change updates the rbwebhooks extension for Review Board 4.0/Django 1.11. It also updates the code to use six moves for urllib, and adds docstrings. Testing Done: Activated the extension and played with the settings.	4155f1ddc394a5424efd35ce8c675f2cf35b30f2
	Modernize rbwebhooks for Review Board 4.0. This change updates the rbwebhooks extension for Review Board 4.0/Django 1.11. It also updates the code to use six moves for urllib, and adds docstrings. Testing Done: Activated the extension and played with the settings.	3e9e7a66d32d19c41347c3510ee704be21b7a853

Diff:

Revision 2 (+226 -110)

Show changes

	rbwebhooks/rbwebhooks/admin.py
	rbwebhooks/rbwebhooks/admin_urls.py
	rbwebhooks/rbwebhooks/extension.py
	rbwebhooks/rbwebhooks/forms.py
	rbwebhooks/rbwebhooks/handlers.py
	rbwebhooks/rbwebhooks/models.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbwebhooks/rbwebhooks/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F841 local variable 'attemps' is assigned to but never used
```
rbwebhooks/rbwebhooks/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F821 undefined name 'attempts'
```

Commits:

	Summary	ID
	Modernize rbwebhooks for Review Board 4.0. This change updates the rbwebhooks extension for Review Board 4.0/Django 1.11. It also updates the code to use six moves for urllib, and adds docstrings. Testing Done: Activated the extension and played with the settings.	3e9e7a66d32d19c41347c3510ee704be21b7a853
	Modernize rbwebhooks for Review Board 4.0. This change updates the rbwebhooks extension for Review Board 4.0/Django 1.11. It also updates the code to use six moves for urllib, and adds docstrings. Testing Done: Activated the extension and played with the settings.	192c8af91d8b96e1b2da9604965738a8ee5d68d6

Diff:

Revision 3 (+226 -110)

Show changes

	rbwebhooks/rbwebhooks/admin.py
	rbwebhooks/rbwebhooks/admin_urls.py
	rbwebhooks/rbwebhooks/extension.py
	rbwebhooks/rbwebhooks/forms.py
	rbwebhooks/rbwebhooks/handlers.py
	rbwebhooks/rbwebhooks/models.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbwebhooks/rbwebhooks/extension.py (Diff revision 3)
The issue has been resolved. Show all issues
```
These should be in alphabetical order.
```
rbwebhooks/rbwebhooks/extension.py (Diff revision 3)
The issue has been resolved. Show all issues
```
While here, can you correct the type on "bennificial"?
```

Status:: Completed
Change Summary:: Pushed to master (9571132)