Modernize rbslack and add a deprecation warning.

Review Request #11058 — Created June 25, 2020 and submitted

david
rb-extension-pack
master
rb-extension-pack

This change modernizes the rbslack extension to work with Review Board
4.0 and Django 1.11. This involves updating the urlpatterns and the
handler for the review_request_closed signal, and fixing up
documentation throughout.

I've also decided to add a warning to the extension's description that
it is deprecated and will be removed soon, so hopefully all this work is
actually moot.

Loaded the slack integration and saw that things worked as expected.

Summary
Modernize rbslack and add a deprecation warning.
Description From Last Updated

These should be in the same import group.

chipx86chipx86

Same nit.

chipx86chipx86

Nit: Can you move the ) to the following line? That's more in line with how we tend to have ...

chipx86chipx86
chipx86
  1. 
      
  2. rbslack/rbslack/admin_urls.py (Diff revision 1)
     
     
     
     

    These should be in the same import group.

  3. rbslack/rbslack/extension.py (Diff revision 1)
     
     
     
     
     

    Same nit.

  4. rbslack/setup.py (Diff revision 1)
     
     
     
     

    Nit: Can you move the ) to the following line? That's more in line with how we tend to have multi-line strings.

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (d674589)
Loading...